Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skrifa optional #104

Closed
IvanUkhov opened this issue Nov 27, 2024 · 3 comments · Fixed by #106
Closed

Make skrifa optional #104

IvanUkhov opened this issue Nov 27, 2024 · 3 comments · Fixed by #106

Comments

@IvanUkhov
Copy link
Contributor

Would it be of interest to hide the parser behind a feature and make it possible to instantiate the checker by providing it all the necessary pieces of information, such as a character map and feature names, directly? The goal is to reduce the number of dependencies and leave it up to the end user how the parsing is done.

@simoncozens
Copy link
Collaborator

I'm not sure that's possible. It's called "shaper"glot for a reason. :-) How would you handle the shaping?

@IvanUkhov IvanUkhov changed the title Make the parser optional Make skrifa optional Nov 28, 2024
@IvanUkhov
Copy link
Contributor Author

IvanUkhov commented Nov 28, 2024

I suppose there are two font parsers involved: read-fonts and ttf-parser. The latter is part of harfruzz, and it is indeed needed for shaping. The former, however, is used for extracting the glyph names, features, and character mapping, which can be done ahead of time and potentially by other parsers. I opened a PR to illustrate the idea. Again, if there is interest from your side.

@simoncozens
Copy link
Collaborator

(The aim of harfruzz is to kick out ttf-parser and replace it with read-fonts, so we have read-fonts on both sides. But I'm not seeing a lot of progress towards that aim right now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants