Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functools.cache is python>=3.9 #27

Closed
felipesanches opened this issue Jul 18, 2023 · 0 comments
Closed

functools.cache is python>=3.9 #27

felipesanches opened this issue Jul 18, 2023 · 0 comments
Assignees
@felipesanches

Comments

@felipesanches
Copy link
Member

But the project is declared as supporting python >=3.7 (at https://github.com/googlefonts/shaperglot/blob/main/pyproject.toml#L31)

"The documentation for functools.cache states that it's only available from Python 3.9 onwards. If you're using an earlier version then the documentation also states that it's the same as using lru_cache(maxsize=None), so that's probably your best option."

--source: https://stackoverflow.com/a/66846753
felipesanches added a commit to felipesanches/shaperglot that referenced this issue Jul 18, 2023
@felipesanches
Use @lru_cache(maxsize=None) instead of @cache
28abbea 
so that the program can be used not only on python 3.9, but also on 3.7 and 3.8
(issue googlefonts#27)
@felipesanches felipesanches self-assigned this Jul 18, 2023
@felipesanches felipesanches mentioned this issue Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simoncozens @felipesanches