Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output contains unnecessary messages triggered by already-reported problems #63

Closed
bobh0303 opened this issue Apr 19, 2024 · 2 comments
Closed

Comments

@bobh0303
Copy link

When font is missing a character needed for a particular language, one output message is sufficient. Subsequent tests that depend on that character needn't be run.

Example:

Font does not fully support language 'ur_Arab'
 * FAIL: Some base glyphs were missing: ٹ, چ, ڈ, ڑ, ھ, ہ
 * FAIL: Shaper produced a .notdef
 * FAIL: .fina version of ARABIC LETTER TTEH; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .medi version of ARABIC LETTER TTEH; both buffers returned space=1+0|.notdef=1+1033|space=0+0
 * FAIL: .init version of ARABIC LETTER TTEH; both buffers returned space=0+0|.notdef=0+1033
 * FAIL: .fina version of ARABIC LETTER TCHEH; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .medi version of ARABIC LETTER TCHEH; both buffers returned space=1+0|.notdef=1+1033|space=0+0
 * FAIL: .init version of ARABIC LETTER TCHEH; both buffers returned space=0+0|.notdef=0+1033
 * FAIL: .fina version of ARABIC LETTER DDAL; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .fina version of ARABIC LETTER RREH; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .fina version of ARABIC LETTER HEH GOAL; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .medi version of ARABIC LETTER HEH GOAL; both buffers returned space=1+0|.notdef=1+1033|space=0+0
 * FAIL: .init version of ARABIC LETTER HEH GOAL; both buffers returned space=0+0|.notdef=0+1033
 * FAIL: .fina version of ARABIC LETTER HEH DOACHASHMEE; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: .medi version of ARABIC LETTER HEH DOACHASHMEE; both buffers returned space=1+0|.notdef=1+1033|space=0+0
 * FAIL: .init version of ARABIC LETTER HEH DOACHASHMEE; both buffers returned space=0+0|.notdef=0+1033

Only the first Fail is needed — all the rest are redundant.

Test info:

Command: shaperglot check Alkalami-Regular.ttf ur_Arab
Font download: https://software.sil.org/alkalami/download/

System info:

Python 3.10.12
shaperglot: 0.5.0
Ubuntu: 22:04

Replaces fonttools/fontbakery#4654

@bobh0303
Copy link
Author

For fa_Arab I get other kinds of messages related to previously reported missing base chars:

Font does not fully support language 'fa_Arab'
 * FAIL: Some base glyphs were missing: چ
 * FAIL: Shaper produced a .notdef
 * FAIL: .fina version of ARABIC LETTER TCHEH; both buffers returned .notdef=1+1033|space=0+0
 * FAIL: Shaper didn't attach uni064B to None
 * FAIL: Shaper produced a .notdef
 * FAIL: Shaper didn't attach uni064D to None
 * FAIL: Shaper produced a .notdef
 * FAIL: Shaper didn't attach uni064C to None
 * FAIL: Shaper produced a .notdef
 * FAIL: Shaper didn't attach uni0651 to None
 * FAIL: Shaper produced a .notdef
 * FAIL: Shaper didn't attach uni0654 to None
 * FAIL: Shaper produced a .notdef
...

@simoncozens
Copy link
Collaborator

Thanks for re-filing this here; I'll work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants