Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListStores should support pagination #345

Open
yuryu opened this issue Jul 7, 2022 · 2 comments
Open

ListStores should support pagination #345

yuryu opened this issue Jul 7, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@yuryu
Copy link
Member

yuryu commented Jul 7, 2022

ListStores should support pagination because it returns N results.

@hongalex
Copy link
Collaborator

hongalex commented Jul 7, 2022

We should add pagination options to ListStores, similar to Pub/Sub

Alternative considered was to make it streaming but streaming endpoints are harder to use than unary and is overkill for ListStores.

@yuryu yuryu added the enhancement New feature or request label Jul 14, 2022
@yuryu yuryu added this to the v1.0.0-alpha0 milestone Jul 18, 2022
@yuryu
Copy link
Member Author

yuryu commented Jul 22, 2022

Making ListStores pageable won't break compatibility, so I'll change the issue and remove the 1.0.0 tag.

@yuryu yuryu changed the title ListStores should be streaming ListStores should support pagination Jul 22, 2022
@yuryu yuryu removed this from the v1.0.0-alpha0 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants