Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use direct method for open_saves_test.go #384

Open
hongalex opened this issue Sep 7, 2022 · 0 comments
Open

test: use direct method for open_saves_test.go #384

hongalex opened this issue Sep 7, 2022 · 0 comments

Comments

@hongalex
Copy link
Collaborator

hongalex commented Sep 7, 2022

Tests in internal/app/server/open_saves_test.go should use server.Run() directly. We should also modify Run() to accept a Listener instead of direct network address/port so that these tests can use bufconn instead.

Spawned from discussion from #382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hongalex