Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readiness checks to /examples #818

Closed
markmandel opened this issue Oct 11, 2023 · 0 comments · Fixed by #821
Closed

Add readiness checks to /examples #818

markmandel opened this issue Oct 11, 2023 · 0 comments · Fixed by #821
Labels
area/examples Examples. Usually found in the `examples` directory
Milestone
0.7.0

Comments

@markmandel
Copy link
Member

The examples don't have readiness checks, we should add them.

Particularly once #802 has merged.
@markmandel markmandel added the area/examples Examples. Usually found in the `examples` directory label Oct 11, 2023
@markmandel markmandel added this to the 0.7.0 milestone Oct 12, 2023
markmandel added a commit to markmandel/quilkin that referenced this issue Oct 13, 2023
@markmandel
Examples: Update readiness and liveness checks.
e63a9af 
This adds readiness checks to the xds and relay examples, and updates
the liveness checks to be more aggressive than their previous
configuration.

Also fixed a small formatting issue in the admin docs (newline between
tables).

Closes googleforgames#818
markmandel added a commit to markmandel/quilkin that referenced this issue Oct 13, 2023
@markmandel
Examples: Update readiness and liveness checks.
1d8e88a 
This adds readiness checks to the xds and relay examples, and updates
the liveness checks to be more aggressive than their previous
configuration.

Also fixed a small formatting issue in the admin docs (newline between
tables).

Closes googleforgames#818
@markmandel markmandel mentioned this issue Oct 13, 2023
Merged
XAMPPRocky pushed a commit that referenced this issue Oct 14, 2023
@markmandel
Examples: Update readiness and liveness checks. (#821)
cdd3e82 
This adds readiness checks to the xds and relay examples, and updates
the liveness checks to be more aggressive than their previous
configuration.

Also fixed a small formatting issue in the admin docs (newline between
tables).

Closes #818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Examples: Update readiness and liveness checks. markmandel/quilkin
1 participant
@markmandel