Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-step check for proto submodules #838

Open
XAMPPRocky opened this issue Oct 27, 2023 · 2 comments
Open

Add build-step check for proto submodules #838

XAMPPRocky opened this issue Oct 27, 2023 · 2 comments

Comments

@XAMPPRocky
Copy link
Collaborator

Currently if you download and run cargo build you get an unintuitive error message about missing proto files, before building the protobuf in build.rs we should check if the modules are present, and tell people to run git submodule update --init first.

@markmandel
Copy link
Member

Should probably also add to our docs here as well https://googleforgames.github.io/quilkin/main/book/installation.html

@markmandel
Copy link
Member

markmandel commented Jun 12, 2024

@XAMPPRocky we can close this now, since we vendor and generate protos at develop time, not build time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants