Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust code generated from protobufs should be in source control #864

Closed
Jake-Shadle opened this issue Nov 22, 2023 · 1 comment
Closed

Rust code generated from protobufs should be in source control #864

Jake-Shadle opened this issue Nov 22, 2023 · 1 comment
Labels
kind/bug Something isn't working

Comments

@Jake-Shadle
Copy link
Collaborator

When doing cross-compilation just now I had to install make because of protobuf-src, which reminded me that this project is building protobuf from source as well as generating the Rust code during build. This is extremely expensive in build time, particularly for CI. It would be much nicer to commit the generated Rust code to remove the entirety of the build time cost. They would only need to be regenerated when updating tonic/prost or the protobufs themselves. This can be done via a tool like https://github.com/EmbarkStudios/proto-gen that can also validate the generated code is up to date if needed.

@Jake-Shadle Jake-Shadle added the kind/bug Something isn't working label Nov 22, 2023
@Jake-Shadle
Copy link
Collaborator Author

This was resolved in #896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant