Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for xDS Delta API #885

Open
markmandel opened this issue Dec 14, 2023 · 4 comments
Open

Documentation for xDS Delta API #885

markmandel opened this issue Dec 14, 2023 · 4 comments
Labels
kind/documentation Improvements or additions to documentation

Comments

@markmandel
Copy link
Member

With the implementation of #792 we should update our xDS documentation to reflect this change.

Just digging into the implementation, these are the pages that need updating:

I don't think there is anything else?

@markmandel markmandel added the kind/documentation Improvements or additions to documentation label Dec 14, 2023
@markmandel markmandel changed the title Documentation for xDS API Documentation for xDS Delta API Dec 14, 2023
@XAMPPRocky
Copy link
Collaborator

I think it depends on #884 because the changes in that issue would change the documentation, since we would change the types, and thus the documentation, and I'm reluctant to write docs that'd only be valid for one commit.

@markmandel
Copy link
Member Author

I think it depends on #884 because the changes in that issue would change the documentation, since we would change the types, and thus the documentation, and I'm reluctant to write docs that'd only be valid for one commit.

I guess the only mitigating factor would be that if we want to cut a release, we would have an undocumented API surface at release time -- but we can make that decision when we are ready to make a new release 👍🏻

@XAMPPRocky
Copy link
Collaborator

XAMPPRocky commented Jan 8, 2024

I guess the only mitigating factor would be that if we want to cut a release

I think regardless of this specific feature, I think we want to move away from instant feature stability from version releases. As once we've started shipping "stable" versions, we're still going to want to merge features incrementally.

@markmandel
Copy link
Member Author

markmandel commented Jan 9, 2024

I think regardless of this specific feature, I think we want to move away from instant feature stability from version releases. As once we've started shipping "stable" versions, we're still going to want to merge features incrementally.

100% Agreed (we use feature gates in Agones for exactly the same reason) - but even some kind of non-stable documentation with a warning of stability guarantee, would be useful if we do cut a release, so that end users can at least play with it and give feedback, etc.

For example, this is what we do on Agones:
https://agones.dev/site/docs/guides/player-tracking/

Not wedded to the format, but it's definitely useful for exactly the reasons you describe 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants