Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add note about measure units of jitter metric #1014

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

zifter
Copy link
Contributor

@zifter zifter commented Sep 4, 2024

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
This PR improves documentation

Copy link

google-cla bot commented Sep 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added kind/documentation Improvements or additions to documentation size/xs labels Sep 4, 2024
@XAMPPRocky XAMPPRocky enabled auto-merge (squash) September 4, 2024 14:57
auto-merge was automatically disabled September 4, 2024 14:57

Head branch was pushed to by a user without write access

@zifter zifter force-pushed the improve/add-note-for-metrics branch from 1b2d7bb to 1c1768d Compare September 4, 2024 14:57
@XAMPPRocky
Copy link
Collaborator

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky enabled auto-merge (squash) September 4, 2024 14:57
@XAMPPRocky
Copy link
Collaborator

@markmandel I think something went wrong with cloud build.

@XAMPPRocky
Copy link
Collaborator

@zifter Oh you, also need to sign the CLA for this be merged.

@zifter
Copy link
Contributor Author

zifter commented Sep 5, 2024

@XAMPPRocky i've done it a long time ago
there is an issue with bot, not with my CLA
4ef2ec2 Author: @quilkin-bot <84364394+quilkin-bot​@users.noreply.github.com>

@markmandel
Copy link
Member

Weird, the quilkin bot is failing CLA. It shouldn't be a thing that it even worries about. I'll override it if need be.

@markmandel
Copy link
Member

/gcbrun

(this is needed for people who don't have read access to the repo so the Cloud Build script runs - I forgot this as well)

@markmandel
Copy link
Member

Ah, found the issue with the bot, that should be fixed now. Weird flake in the unit tests:

---- ipv6_firewall_allow stdout ----
thread 'ipv6_firewall_allow' panicked at src/components/proxy.rs:94:91:
called `Result::unwrap()` on an `Err` value: Os { code: 98, kind: AddrInUse, message: "Address already in use" }
stack backtrace:
   0: rust_begin_unwind
             at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/std/src/panicking.rs:647:5
   1: core::panicking::panic_fmt
             at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/panicking.rs:72:14
   2: core::result::unwrap_failed
             at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/result.rs:1649:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/result.rs:1073:23

Will retry.

@zifter
Copy link
Contributor Author

zifter commented Oct 7, 2024

any updates? :)

@markmandel
Copy link
Member

whoops! Thanks for the ping.

@markmandel
Copy link
Member

/gcbrun

@XAMPPRocky XAMPPRocky merged commit a3fcf72 into googleforgames:main Oct 8, 2024
10 checks passed
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 2c007a4d-1aeb-4ff9-afa5-9d7fc0a4cecb

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/1014/head:pr_1014 && git checkout pr_1014
cargo build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants