-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: add note about measure units of jitter metric #1014
improvement: add note about measure units of jitter metric #1014
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Head branch was pushed to by a user without write access
1b2d7bb
to
1c1768d
Compare
Thank you for your PR, and congrats on your first contribution! 🎉 |
@markmandel I think something went wrong with cloud build. |
@zifter Oh you, also need to sign the CLA for this be merged. |
@XAMPPRocky i've done it a long time ago |
Weird, the quilkin bot is failing CLA. It shouldn't be a thing that it even worries about. I'll override it if need be. |
/gcbrun (this is needed for people who don't have read access to the repo so the Cloud Build script runs - I forgot this as well) |
Ah, found the issue with the bot, that should be fixed now. Weird flake in the unit tests:
Will retry. |
any updates? :) |
whoops! Thanks for the ping. |
/gcbrun |
Build Succeeded 🥳 Build Id: 2c007a4d-1aeb-4ff9-afa5-9d7fc0a4cecb The following development images have been built, and will exist for the next 30 days: To build this version:
|
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
This PR improves documentation