Fix urlskip= with -blocked directive for blocked requests

Related feedback: uBlockOrigin/uBlock-issues#3206 (comment)
gorhill · Oct 28, 2024 · c07db75 · c07db75
1 parent ac45060
commit c07db75
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/js/pagestore.js b/src/js/pagestore.js
@@ -925,8 +925,11 @@ const PageStore = class {
     }
 
     redirectBlockedRequest(fctxt) {
-        const directives = staticNetFilteringEngine.redirectRequest(redirectEngine, fctxt);
-        if ( directives === undefined ) { return; }
+        const directives = staticNetFilteringEngine.redirectRequest(redirectEngine, fctxt) || [];
+        if ( this.urlSkippableResources.has(fctxt.itype) ) {
+            staticNetFilteringEngine.urlSkip(fctxt, true, directives);
+        }
+        if ( directives.length === 0 ) { return; }
         if ( logger.enabled !== true ) { return; }
         fctxt.pushFilters(directives.map(a => a.logData()));
         if ( fctxt.redirectURL === undefined ) { return; }
@@ -1152,6 +1155,7 @@ const PageStore = class {
         µb.FilteringContext.MAIN_FRAME,
         µb.FilteringContext.MEDIA,
         µb.FilteringContext.OBJECT,
+        µb.FilteringContext.OTHER,
         µb.FilteringContext.SUB_FRAME,
     ]);