Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add version numbers to filenames and details #30

Open
n00b001 opened this issue Feb 2, 2025 · 2 comments
Open

Please add version numbers to filenames and details #30

n00b001 opened this issue Feb 2, 2025 · 2 comments

Comments

@n00b001
Copy link

n00b001 commented Feb 2, 2025

Hello

Can you please add the version within the zip filename and optionally within the unextracted binary filename

Also optionally, can you please also put the version in the details of the binary:

Image

The reason is, I have a script that downloads a new version of this binary and I'd prefer it didn't run every time (but currently there is no easy way to check if I have the latest version)

@thxCode
Copy link
Collaborator

thxCode commented Feb 3, 2025

for the zip filename, this is a reasonable requirement, but we already get the version in the GitHub download URL, e.g: https://github.com/gpustack/llama-box/releases/download/v0.0.114/llama-box-$os-$arch-$var.zip. Can we solve this by renaming it or relocating it at unzipping? on the other hand, the gpustack/gpustack is using the same logic to support the special version llama-box, so if we change the zip filename here, we should confirm the gpustack has accepted this change request before.

for the embedded properties, we will have a try, but it is not urgent. we like to use the traditional style to export the version information by calling --version.

@n00b001
Copy link
Author

n00b001 commented Feb 3, 2025

@thxCode that's a good point, I have a few options to work around this, thank you

Feel free to pause this issue and deprioritise it to the bottom of the pile!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants