fix(rout53): Adding stage suffix for API - A records

Author: despock

src/lib/manager/route53Manager.ts

@@ -156,8 +156,12 @@ export class Route53Manager {
     apiDomain: apig.DomainName,
     hostedZone: route53.IHostedZone
   ) {
+    let apiRecordName = ''
+    if (recordName && recordName !== '')
+      apiRecordName = scope.isProductionStage() ? `${recordName}` : `${recordName}-${scope.props.stage}`
+
     const apiARecord = new route53.ARecord(scope, `${id}`, {
-      recordName: recordName,
+      recordName: apiRecordName,
       target: route53.RecordTarget.fromAlias(new route53Targets.ApiGatewayDomain(apiDomain)),
       zone: hostedZone,
     })

src/test/construct/graphQLApiLambda.test.ts

@@ -156,7 +156,7 @@ describe('TestGraphQLApiLambdaConstruct', () => {
 describe('TestGraphQLApiLambdaConstruct', () => {
   test('provisions route53 records as expected', () => {
     template.hasResourceProperties('AWS::Route53::RecordSet', {
-      Name: 'api.test.gradientedge.io.',
+      Name: 'api-test.test.gradientedge.io.',
       Type: 'A',
     })
   })

src/test/manager/route53Manager.test.ts

@@ -162,7 +162,7 @@ describe('TestRoute53Construct', () => {
 describe('TestRoute53Construct', () => {
   test('provisions new a record as expected', () => {
     template.hasResourceProperties('AWS::Route53::RecordSet', {
-      Name: 'testapi.gradientedge.io.',
+      Name: 'testapi-test.gradientedge.io.',
       Type: 'A',
     })
     template.hasResourceProperties('AWS::Route53::RecordSet', {