fix(azure): Update defaults for cosmosdb and keyvault (#763)

gradientedge · Mar 10, 2025 · 7cd2cd7 · 7cd2cd7
1 parent 9c05367
commit 7cd2cd7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/lib/azure/services/cosmosdb/main.ts b/src/lib/azure/services/cosmosdb/main.ts
@@ -50,6 +50,10 @@ export class AzureCosmosDbManager {
       tags: props.tags ?? {
         environment: scope.props.stage,
       },
+      defaultIdentityType: props.defaultIdentityType || 'SystemAssignedIdentity',
+      identity: props.identity || {
+        type: 'SystemAssigned',
+      },
     })
 
     createAzureTfOutput(`${id}-cosmosdbAccountName`, scope, cosmosdbAccount.name)

diff --git a/src/lib/azure/services/key-vault/main.ts b/src/lib/azure/services/key-vault/main.ts
@@ -45,7 +45,9 @@ export class AzureKeyVaultManager {
       name: scope.resourceNameFormatter.format(props.name, scope.props.resourceNameOptions?.keyVault),
       location: resourceGroup.location,
       resourceGroupName: resourceGroup.name,
-      skuName: props.skuName ?? 'standard',
+      skuName: props.skuName || 'standard',
+      enableRbacAuthorization: props.enableRbacAuthorization || true,
+      softDeleteRetentionDays: props.softDeleteRetentionDays || 90,
       tags: props.tags ?? {
         environment: scope.props.stage,
       },