Strike-through incorrect property values

gradle · Jun 14, 2024 · b01bea8 · b01bea8
1 parent 6490428
commit b01bea8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/gradle-client/src/jvmMain/kotlin/org/gradle/client/ui/composables/Texts.kt b/gradle-client/src/jvmMain/kotlin/org/gradle/client/ui/composables/Texts.kt
@@ -9,6 +9,7 @@ import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.alpha
 import androidx.compose.ui.text.AnnotatedString
+import androidx.compose.ui.text.TextStyle
 import androidx.compose.ui.text.font.FontFamily
 import org.gradle.client.ui.theme.spacing
 import org.gradle.client.ui.theme.transparency
@@ -59,11 +60,11 @@ fun LabelSmall(text: String, modifier: Modifier = Modifier) {
 }
 
 @Composable
-fun LabelMedium(text: String, modifier: Modifier = Modifier) {
+fun LabelMedium(text: String, textStyle: TextStyle = TextStyle.Default, modifier: Modifier = Modifier) {
     Text(
         modifier = modifier,
         text = text,
-        style = MaterialTheme.typography.labelMedium,
+        style = textStyle.plus(MaterialTheme.typography.labelMedium),
     )
 }
 

diff --git a/...ient/src/jvmMain/kotlin/org/gradle/client/ui/connected/actions/GetDeclarativeDocuments.kt b/...ient/src/jvmMain/kotlin/org/gradle/client/ui/connected/actions/GetDeclarativeDocuments.kt
@@ -16,7 +16,9 @@ import androidx.compose.ui.draw.alpha
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.input.pointer.PointerIcon
 import androidx.compose.ui.input.pointer.pointerHoverIcon
+import androidx.compose.ui.text.TextStyle
 import androidx.compose.ui.text.input.KeyboardType
+import androidx.compose.ui.text.style.TextDecoration
 import androidx.compose.ui.unit.times
 import org.gradle.client.build.action.GetResolvedDomAction
 import org.gradle.client.build.model.ResolvedDomPrerequisites
@@ -31,6 +33,7 @@ import org.gradle.declarative.dsl.schema.DataProperty
 import org.gradle.declarative.dsl.schema.SchemaMemberFunction
 import org.gradle.internal.declarativedsl.dom.DeclarativeDocument
 import org.gradle.internal.declarativedsl.dom.DocumentResolution.ElementResolution.SuccessfulElementResolution.ContainerElementResolved
+import org.gradle.internal.declarativedsl.dom.DocumentResolution.PropertyResolution.PropertyAssignmentResolved
 import org.gradle.internal.declarativedsl.dom.data.NodeData
 import org.gradle.internal.declarativedsl.dom.data.collectToMap
 import org.gradle.internal.declarativedsl.dom.mutation.*
@@ -377,11 +380,15 @@ class ModelTreeRendering(
         property: DataProperty
     ) {
         WithDecoration(propertyNode) {
+            val maybeInvalidDecoration =
+                if (propertyNode != null && resolutionContainer.data(propertyNode) !is PropertyAssignmentResolved)
+                    TextDecoration.LineThrough else TextDecoration.None
             LabelMedium(
                 modifier = Modifier.padding(bottom = MaterialTheme.spacing.level2)
                     .withHoverCursor()
                     .withClickTextRangeSelection(propertyNode, highlightingContext)
                     .semiTransparentIfNull(propertyNode),
+                textStyle = TextStyle(textDecoration = maybeInvalidDecoration),
                 text = "${property.name}: ${property.kotlinType.simpleName} = ${
                     propertyNode?.value?.sourceData?.text() ?: NOTHING_DECLARED
                 }"