Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal scroll bar to model content panes #8

Merged
merged 4 commits into from
Jul 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,27 +1,23 @@
package org.gradle.client.ui.composables

import androidx.compose.foundation.horizontalScroll
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.text.selection.SelectionContainer
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.text.font.FontFamily

@Composable
fun FailureContent(exception: Exception) {
Column(
modifier = Modifier.fillMaxSize().horizontalScroll(rememberScrollState())
) {
SelectionContainer {
Text(
text = exception.stackTraceToString(),
style = MaterialTheme.typography.labelSmall.copy(fontFamily = FontFamily.Monospace),
color = MaterialTheme.colorScheme.error,
)
Column {
horizontalScrollContent {
SelectionContainer {
Text(
text = exception.stackTraceToString(),
style = MaterialTheme.typography.labelSmall.copy(fontFamily = FontFamily.Monospace),
color = MaterialTheme.colorScheme.error,
)
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
package org.gradle.client.ui.composables

import androidx.compose.foundation.HorizontalScrollbar
import androidx.compose.foundation.horizontalScroll
import androidx.compose.foundation.layout.*
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.rememberScrollbarAdapter
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp


@Composable
fun horizontalScrollContent(
content: @Composable ColumnScope.() -> Unit,
) {
Box(
modifier = Modifier.fillMaxSize()
) {
val stateHorizontal = rememberScrollState(0)

Box(
modifier = Modifier
.fillMaxSize()
.padding(bottom = 12.dp)
.horizontalScroll(stateHorizontal)
) {
Column {
content()
}
}

HorizontalScrollbar(
modifier = Modifier
.align(Alignment.BottomStart)
.fillMaxWidth(),
adapter = rememberScrollbarAdapter(stateHorizontal)
)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import androidx.compose.foundation.layout.ColumnScope
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import org.gradle.client.ui.composables.horizontalScrollContent
import org.gradle.tooling.model.build.BuildEnvironment

class GetBuildEnvironment : GetModelAction<BuildEnvironment> {
Expand All @@ -15,29 +16,31 @@ class GetBuildEnvironment : GetModelAction<BuildEnvironment> {

@Composable
override fun ColumnScope.ModelContent(model: BuildEnvironment) {
Text(
text = "Build Environment",
style = MaterialTheme.typography.titleMedium
)
Text(
text = "Build Identifier: ${model.buildIdentifier.rootDir}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Java Home: ${model.java.javaHome}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "JVM Arguments: ${model.java.jvmArguments}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Gradle Version: ${model.gradle.gradleVersion}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Gradle User Home: ${model.gradle.gradleUserHome}",
style = MaterialTheme.typography.labelSmall
)
horizontalScrollContent {
Text(
text = "Build Environment",
style = MaterialTheme.typography.titleMedium
)
Text(
text = "Build Identifier: ${model.buildIdentifier.rootDir}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Java Home: ${model.java.javaHome}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "JVM Arguments: ${model.java.jvmArguments}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Gradle Version: ${model.gradle.gradleVersion}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Gradle User Home: ${model.gradle.gradleUserHome}",
style = MaterialTheme.typography.labelSmall
)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import androidx.compose.foundation.layout.ColumnScope
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import org.gradle.client.ui.composables.horizontalScrollContent
import org.gradle.tooling.model.gradle.GradleBuild

class GetGradleBuild : GetModelAction<GradleBuild> {
Expand All @@ -15,21 +16,23 @@ class GetGradleBuild : GetModelAction<GradleBuild> {

@Composable
override fun ColumnScope.ModelContent(model: GradleBuild) {
Text(
text = "Gradle Build",
style = MaterialTheme.typography.titleMedium
)
Text(
text = "Build Identifier: ${model.buildIdentifier.rootDir}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Root Project Identifier: ${model.rootProject.projectIdentifier}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Root Project Name: ${model.rootProject.name}",
style = MaterialTheme.typography.labelSmall
)
horizontalScrollContent {
Text(
text = "Gradle Build",
style = MaterialTheme.typography.titleMedium
)
Text(
text = "Build Identifier: ${model.buildIdentifier.rootDir}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Root Project Identifier: ${model.rootProject.projectIdentifier}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Root Project Name: ${model.rootProject.name}",
style = MaterialTheme.typography.labelSmall
)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import androidx.compose.foundation.layout.ColumnScope
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import org.gradle.client.ui.composables.horizontalScrollContent
import org.gradle.tooling.model.GradleProject

class GetGradleProject : GetModelAction<GradleProject> {
Expand All @@ -15,21 +16,23 @@ class GetGradleProject : GetModelAction<GradleProject> {

@Composable
override fun ColumnScope.ModelContent(model: GradleProject) {
Text(
text = "Gradle Project",
style = MaterialTheme.typography.titleMedium
)
Text(
text = "Root Project Identifier: ${model.projectIdentifier}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Root Project Name: ${model.name}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Root Project Description: ${model.description}",
style = MaterialTheme.typography.labelSmall
)
horizontalScrollContent {
Text(
text = "Gradle Project",
style = MaterialTheme.typography.titleMedium
)
Text(
text = "Root Project Identifier: ${model.projectIdentifier}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Root Project Name: ${model.name}",
style = MaterialTheme.typography.labelSmall
)
Text(
text = "Root Project Description: ${model.description}",
style = MaterialTheme.typography.labelSmall
)
}
}
}