Bugfix: Allow to compile with C++17 #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabyx
force-pushed
the
bugfix/c++17-support
branch
from
4213daf to
78acbfa
Compare
gabyx
force-pushed
the
bugfix/c++17-support
branch
from
78acbfa to
06949aa
Compare
|
We went through a long period of waiting and discussion about this and the decision seems to have to been to make C++17 required. I ended up forking it and making a couple of changes: https://github.com/asmaloney/crossguid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please merge this, this enables string_view only when compiling with
c++17support.