Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: improve page-limits handling #302

Open
gabor opened this issue May 3, 2024 · 2 comments
Open

feature request: improve page-limits handling #302

gabor opened this issue May 3, 2024 · 2 comments
Labels
type/feature-request Requested new feature or enhancement

Comments

@gabor
Copy link
Contributor

gabor commented May 3, 2024

we have some hardcoded page limits in the code, for example:

we should increase these, but if we increase them too much we'll hit rate limits. some ideas:

  1. make these user-configurable
  2. warn the user if they are trying to fetch too much data

(see #232 for more context)

@gabor gabor moved this to Backlog in OSS Big Tent May 3, 2024
@gabor gabor added the type/feature-request Requested new feature or enhancement label May 3, 2024
@natellium
Copy link

I ran into this yesterday. The project I was querying has hundreds of closed issues, so no matter what I did I only got the first bunch. It also seems the filters are applied after the query, so I couldn't work around the limit either 😞

@trevjonez
Copy link

Possibly related given apps have much higher rate limits compared to a user PAT.
#88

Another thing that could help is using the logged in users auth since that could scale better for concurrent users compared to using app auth

https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Requested new feature or enhancement
Projects
Status: Backlog
Development

No branches or pull requests

3 participants