[loki-distributed] remove deprecated flag from compactor deployment #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gasmick <[email protected]>
zanhsieh
approved these changes
Jan 25, 2024
|
Is there anything that can be done to speed up the completion of this pull request? |
Signed-off-by: gasmick <[email protected]>
Footur
approved these changes
Apr 9, 2024
|
@zalegrala I'm so sorry for bothering you! Could you please take a look at this pull request and merge it? If you have any ideas on how we can all work together to make sure the Edit: I've seen that the Loki distributed community Helm Chart is going to be replaced by the official Loki Helm Chart. For context. 🎉 |
zalegrala
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the hardcoded, deprecated
boltdb.shipper.compactor.working-directoryflag in the Compactor Deployment template, so that it can be set with.Values.compactor.extraArgsand thecompactor.working-directoryflag if necessary.