Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small typo on documentation AWS Signature v4 documentation #103

Closed
huima opened this issue May 3, 2024 · 2 comments
Closed

Small typo on documentation AWS Signature v4 documentation #103

huima opened this issue May 3, 2024 · 2 comments
Assignees
@oleiade
Labels
documentation Improvements or additions to documentation

Comments

@huima
Copy link

huima commented May 3, 2024

On page: https://grafana.com/docs/k6/latest/javascript-api/jslib/aws/signaturev4/

The Signature v4 option object descriptions on credentials part lists 'secretAccessKeyId' even though code uses secretAccessKey.
@github-actions github-actions bot added the triage label May 3, 2024
@oleiade
Copy link
Member

oleiade commented May 13, 2024

Hey @huima 👋🏻

Thanks a lot for pointing this out, you're correct, we'll address that as soon as possible 🤝

@oleiade oleiade added documentation Improvements or additions to documentation and removed triage labels May 13, 2024
@oleiade oleiade mentioned this issue May 13, 2024
Merged
7 tasks
@oleiade
Copy link
Member

oleiade commented May 13, 2024

This will be addressed by: grafana/k6-docs#1585

@joanlopez joanlopez assigned oleiade and unassigned joanlopez May 13, 2024
@oleiade oleiade closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleiade oleiade

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oleiade @huima @joanlopez