Chore: Migrate #99348 from grafana/grafana #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangkb09
commented
Jan 30, 2025
Comment on lines
+116
to
+120
| if (!this._metricsMetadata && !ds.languageProvider.metricsMetadata) { | ||
| await ds.languageProvider.loadMetricsMetadata(); | ||
| this._metricsMetadata = ds.languageProvider.metricsMetadata; | ||
| } | ||
|
|
There was a problem hiding this comment.
i removed the wrapper
if (ds.languageProvider instanceof PromQlLanguageProvider) {
because we're already checking if (ds && above on 106
yangkb09
commented
Jan 30, 2025
| const suffix: string = metric.split('_').pop() ?? ''; | ||
| // the string is not equal to bucket | ||
| const notClassic = suffix !== 'bucket'; | ||
| if (metadata?.[metric]?.type === 'histogram' && notClassic) { |
There was a problem hiding this comment.
i included @NWRichmond 's optional chaining suggestion here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36
Ref: #35
PR in
grafana/grafana: grafana/grafana#99348