Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java-spring-boot example #232

Merged

Conversation

adarshan-intel
Copy link
Contributor

@adarshan-intel adarshan-intel commented Jan 24, 2025

Description of the changes

According to this - #226 (review)
Updated from openjdk-11-jdk to openjdk-21-jdk

How to test this PR?

CI


This change is Reviewable

@adarshan-intel adarshan-intel marked this pull request as ready for review January 24, 2025 06:39
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL), "fixup! " found in commit messages' one-liners

Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, "fixup! " found in commit messages' one-liners

@adarshan-intel
Copy link
Contributor Author

@kailun-qin @mkow Can we merge this?

@kailun-qin kailun-qin force-pushed the adarsh/java-spring-boot branch from d60f6d6 to 10f5e9f Compare February 20, 2025 04:30
Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kailun-qin kailun-qin merged commit 10f5e9f into gramineproject:master Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants