Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom host name in registration #50

Closed
maxfrigge opened this issue Feb 5, 2019 · 1 comment
Closed

Allow custom host name in registration #50

maxfrigge opened this issue Feb 5, 2019 · 1 comment

Comments

@maxfrigge
Copy link

Not sure if this is compliant or not, but it would be cool to set a custom host name when registering a service. This would allow creating a server, which can be found under a predefined domain - e.g. through a web browser.

Right now it looks like this case will always be true, because you cannot actually set HostName. It will thus fallback to os.Hostname() and thus depends on the environment. I have tested it using other values and it resolves and works fine under macOS.

I would be more than happy to create a PR, if you don't mind.

This would probably also help with the use case in #42.

@maxfrigge
Copy link
Author

I have just found that this is what RegisterProxy is for.

Sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant