Merge pull request #2067 from graphcommerce-org/fix/handle-redirect

Implement URL validation to prevent empty values for the HandleRedirect query
graphcommerce-org · Oct 4, 2023 · 1c0f665 · 1c0f665
2 parents 76de862 + 7babf41
commit 1c0f665
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/rich-guests-applaud.md b/.changeset/rich-guests-applaud.md
@@ -0,0 +1,5 @@
+---
+'@graphcommerce/magento-store': patch
+---
+
+Prevent HandleRedirect errors by filtering out empty URL values from the candidates array.
diff --git a/packages/magento-store/utils/redirectOrNotFound.ts b/packages/magento-store/utils/redirectOrNotFound.ts
@@ -67,7 +67,7 @@ export async function redirectOrNotFound(
       candidates.add(from.endsWith(suffix) ? from.slice(0, -suffix.length) : `${from}${suffix}`)
     })
 
-    const routePromises = [...candidates].map(
+    const routePromises = [...candidates].filter(Boolean).map(
       async (url) =>
         (
           await client.query({