Skip to content

Commit

Permalink
Merge pull request #2193 from graphcommerce-org/fix/various
Browse files Browse the repository at this point in the history
Fix/various
  • Loading branch information
paales authored Feb 12, 2024
2 parents 50a1ece + 317250a commit bc66af2
Show file tree
Hide file tree
Showing 12 changed files with 1,955 additions and 1,957 deletions.
5 changes: 5 additions & 0 deletions .changeset/yellow-phones-give.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@graphcommerce/docs": patch
---

Updated docs to reflect featurelist more accurately
672 changes: 336 additions & 336 deletions .yarn/releases/yarn-4.0.2.cjs → .yarn/releases/yarn-4.1.0.cjs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .yarnrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ enableImmutableInstalls: false

nodeLinker: node-modules

yarnPath: .yarn/releases/yarn-4.0.2.cjs
yarnPath: .yarn/releases/yarn-4.1.0.cjs
14 changes: 8 additions & 6 deletions docs/feature-list.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,15 @@ Features taken from the Magento Commerce 2 Feature List
- [x] Blend content and commerce by adding products to content pages and rich
content to product pages. — [Enhanced]
- [x] Create reusable dynamic blocks targeted to customer segments. — [Commerce]
- [x] Easily stage and preview content for seamless updates. — [Enhanced]
- [x] Manage upcoming site changes with a timeline dashboard. [Enhanced]
- [x] Easily stage and preview content for seamless updates. — [Partial]
- [x] Manage upcoming site changes with a timeline dashboard. - [Commerce]
- [x] Organize content pages and add pagination, navigation, and menus with a
page hierarchy tool. — [Enhanced]
- [x] Track and restore previous versions of content pages. — [Enhanced]
- [x] Engage customers with exciting imagery from Adobe Stock, straight from
your Adobe Commerce instance.
- [x] Save content and layouts as templates. Apply them to new areas across
sites and store views.[Enhanced]
sites and store views.
- [x] Provide creatives, designers, and agencies with direct, controlled access
to the Media Gallery.

Expand Down Expand Up @@ -214,7 +214,7 @@ Features taken from the Magento Commerce 2 Feature List
### Checkout

- [x] Include a mini cart on store pages to summarize products in the cart.
- [x] Display an order summary with product images in checkout.
- [x] Display an order summary with product images in checkout. [Todo]
- [x] Offer guest and registered user checkout. Registered customers are
automatically recognized when they enter their email addresses.
- [ ] Boost conversion rates with an Instant Purchase option that uses saved
Expand Down Expand Up @@ -382,7 +382,7 @@ Features taken from the Magento Commerce 2 Feature List
APIs with REST and GraphQL support. — [Enhanced]
- [x] Smoothly manage interactions between extensions using plug-ins and
dependency injection software design patterns. —
[Plugins](https://www.graphcommerce.org/docs/framework/plugins-react_)
[Plugins](https://www.graphcommerce.org/docs/framework/plugins-react)
- [ ] Accelerate time-to-market and improve code quality with a fully-automated
testing framework.
- [ ] Update code with a standalone installer that checks for prerequisites
Expand All @@ -404,10 +404,12 @@ Features taken from the Magento Commerce 2 Feature List
- [x] Feel confident with regular scanning, external penetration testing, and
bug bounty programs that promote core platform security.
- [x] Stay informed about security issues through the Adobe Security Center and
mailing list.
mailing list. [Commerce]
- [x] Prevent private data from sending to third parties with Egress Filtering.
[Commerce]
- [x] Support for leading iPaaS platforms to enable enterprise integrations
- [x] Optimize your upgrade process with the Upgrade Compatibility Tool.
[Commerce]

### Layout and theming

Expand Down
30 changes: 10 additions & 20 deletions docs/framework/troubleshooting.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,24 @@
If any errors are detected during the build phase, the console and browser will
display an error message. Common causes for errors are:

```bash
[next] [GraphQL Errors] failed to fetch to https://magento.test/graphql products
```

You are connecting with a local endpoint with a self signed SSL certicate, start
your dev server with `NODE_TLS_REJECT_UNAUTHORIZED=0 yarn dev`

```bash
[next] 🕸️ - m2: Failed to generate schema: request to [...] failed, reason: connect ETIMEDOUT
```

Missing MAGENTO_ENDPOINT environment variable in your .env file
Missing `magentoEndpoint` in your graphcommerce.config.js

```bash
🕸️ - m2: Failed to generate schema: invalid json response body at [...] reason: Unexpected '<'
```

MAGENTO_ENDPOINT environment variable is not pointing to a Magento graphql
`magentoEndpoint` environment variable is not pointing to a Magento graphql
endpoint

```bash
Expand All @@ -28,24 +35,7 @@ The Magento version is outdated. Make sure you are running Magento 2.4.3 and up
Error: Invalid src prop ([...]) on 'next/image', hostname "[...]" is not configured under images in your 'next.config.js'
```

Add the image domain to IMAGE_DOMAINS in your .env file

```bash
File /[...]/node_modules/@graphcommerce/magento-payment-braint
ree/hooks/UseBraintree.graphql caused error: Unable to find field "createBraintreeClientToken" on type "Mutation"!
```

Remove "@graphcommerce/magento-payment-braintree" from your dependencies in
package.json. Run `yarn` to update dependencies, then run `yarn dev`.

```bash
File /[...]/node_modules/@graphcommerce/mollie-magento-payment
/components/MolliePlaceOrder/MolliePlaceOrder.graphql caused error: Unable to
find field "mollie_redirect_url" on type "Order"!
```

Remove "@graphcommerce/mollie-magento-payment" from your dependencies in
package.json. Run `yarn` to update dependencies, then run `yarn dev`.
Add the image domain to the next.config.js

```bash
node_modules/@graphcommerce/graphql/generated/fragments.json
Expand Down
1 change: 1 addition & 0 deletions docs/getting-started/create.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ start building.

### Requirements

- Lixux, MacOS or WSL2
- Install and use node 16/18: `nvm install 16` or `nvm use 16`
- Install yarn: `corepack enable`

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "root",
"repository": "github:graphcommerce-org/graphcommerce",
"version": "5.0.0",
"packageManager": "yarn@4.0.2",
"packageManager": "yarn@4.1.0",
"private": true,
"workspaces": [
"docs",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable no-console */
import { ApolloLink } from '@apollo/client'
import type { MeshFetchHTTPInformation } from '@graphql-mesh/plugin-http-details-extensions'
import { print } from 'graphql'
import { print } from '@apollo/client/utilities'
import { cliHyperlink } from '../../lib/hyperlinker'

const running = new Map<
Expand Down
2 changes: 1 addition & 1 deletion packages/magento-customer/link/customerLink.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { globalApolloClient } from '@graphcommerce/graphql'
import { ApolloLink, fromPromise, onError, setContext } from '@graphcommerce/graphql/apollo'
import { ErrorCategory } from '@graphcommerce/magento-graphql'
import { GraphQLError } from 'graphql'
import type { GraphQLError } from 'graphql'
import { NextRouter } from 'next/router'
import { signOut } from '../components/SignOutForm/signOut'
import { CustomerTokenDocument } from '../hooks'
Expand Down
8 changes: 4 additions & 4 deletions packages/react-hook-form/src/useGqlDocumentHandler.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,17 @@ export type DeepIsRequired<V> = {
[k in keyof V]-?: undefined extends V[k]
? false
: V[k] extends Record<string, unknown>
? DeepIsRequired<V[k]>
: true
? DeepIsRequired<V[k]>
: true
}

type DeepStringify<V> = {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
[k in keyof V]?: V[k] extends (infer U)[]
? string[]
: V[k] extends Record<string, unknown>
? DeepStringify<V[k]>
: string
? DeepStringify<V[k]>
: string
}

type FieldTypes = LiteralUnion<keyof Scalars, string> | FieldTypes[]
Expand Down
2 changes: 1 addition & 1 deletion packagesDev/graphql-codegen-markdown-docs/src/graphql.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {
import type {
ListTypeNode,
NonNullTypeNode,
NamedTypeNode,
Expand Down
Loading

0 comments on commit bc66af2

Please sign in to comment.