fix: underflow in getIdleStake (TRST-L14)

graphprotocol · Dec 12, 2024 · 04fcd0a · 04fcd0a
1 parent c94be63
commit 04fcd0a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/horizon/contracts/staking/HorizonStakingBase.sol b/packages/horizon/contracts/staking/HorizonStakingBase.sol
@@ -268,11 +268,11 @@ abstract contract HorizonStakingBase is
      * TODO: update the calculation after the transition period.
      */
     function _getIdleStake(address _serviceProvider) internal view returns (uint256) {
-        return
-            _serviceProviders[_serviceProvider].tokensStaked -
-            _serviceProviders[_serviceProvider].tokensProvisioned -
-            _serviceProviders[_serviceProvider].__DEPRECATED_tokensAllocated -
+        uint256 tokensUsed = _serviceProviders[_serviceProvider].tokensProvisioned +
+            _serviceProviders[_serviceProvider].__DEPRECATED_tokensAllocated +
             _serviceProviders[_serviceProvider].__DEPRECATED_tokensLocked;
+        uint256 tokensStaked = _serviceProviders[_serviceProvider].tokensStaked;
+        return tokensStaked > tokensUsed ? tokensStaked - tokensUsed : 0;
     }
 
     /**