Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOS for organization, improvements, processes and documentation #81

Open
10 of 31 tasks
davekaj opened this issue Jan 13, 2021 · 2 comments
Open
10 of 31 tasks

TODOS for organization, improvements, processes and documentation #81

davekaj opened this issue Jan 13, 2021 · 2 comments
Assignees

Comments

@davekaj
Copy link
Contributor

davekaj commented Jan 13, 2021

Organization

  • Remove all fields that are not implemented, or label them NOT IMPLEMENTED
  • Clean up the schema
  • Clean up all the mappings and other files

Improvements to the Subgraph

  • Add in the proxy implementation code (it is commented out and now working)
  • Add a field that shows total delegation fees paid by a delegator, all time
  • Renaming of fields
    • totalStaked on Delegators should really be called totalDelegated
  • Rename all fields and names from signalled to signaled
  • Add collected GRT to the epoch, to go alongside rebate amount
  • Move GRT and transfers out of the main subgraph (some discussion still needed here)
  • Implement GRT in USD and ETH by querying the uniswap subgraph (you could argue this should be in the GRT balances subgraph, as it would cause a ton of txs as well
  • Load AND CREATE all entities by default to avoid future bugs
  • Remove lastRunEpoch

Process improvements

  • Start following standard Graph QL api upgrading procedures
  • Look into hiding deprecated fields in Graph QL
  • Figure out the best way to set up a hook or github action for the subgraph
  • Develop an updating process:
    • Changelog
    • Release versions (on github, no need for NPM right now)
    • For Versions, have the subgraph ID in a file in the code, automatically updated
    • Consider doing monthly updates, and running a dev subgraph and a prod subgraph
  • Linting on push

Documentation for the subgraph

  • Explain parts per million
  • Deep explanation on subgraphs vs. subgraph deployments (might be able to dig up docs on notion)
  • Explain CURRENT and cumulative
  • Explain GRT values are all 10^18
  • Explain how network issuance rate works ( 1.000000012184945188^(3656060*24/13) )
  • Explain subgraph metadata for semantic versioning
  • Document all mappings
  • See if we can autogen docs from the schema
  • See if we can autogen docs from the event signatures
@fordN
Copy link
Contributor

fordN commented Jan 13, 2021

Solid list!

@davekaj I can help out with setting up a github workflow for continuous integration next week.

@juanmardefago
Copy link
Collaborator

This got kinda forgotten amongst the work for the July launch, but we could revisit a few things, and maybe add a few new bullet points like brainstorming ways of splitting the subgraph for better indexing performance (extracting the ERC20 tracking from the core subgraph, dividing subgraph per linked roles, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants