Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open question about calculating total values for the Subgraph Entity #83

Open
davekaj opened this issue Jan 14, 2021 · 1 comment
Open

Comments

@davekaj
Copy link
Contributor

davekaj commented Jan 14, 2021

Values such as:

  • totalIndexingRewards
  • totalQueryFeesCollected
  • totalStake
  • totalSignal

Are ignored in the subgraph for now. Since 2 subgraphs can point to the same existing subgraph deployment.

It is doable, it just involves a lot of work, so it should be done specifically as a task in the near future

@juanmardefago
Copy link
Collaborator

The PR #147 adds batch updates for a specific curation value (currentSignalledTokens), but the logic used to update that value would also work for this issue.

Just as a side note, as in the case of curation, we would be showing "double counted" GRT, since even if they are different subgraphs, for indexers it's the same one, so it will be displayed as two different subgraphs with the same amount of GRT (which is kinda confusing if you don't really understand the details).

I think that "double counted" GRT is fine, and it's the route we decided to go with #147 since when we tried to make it more "subgraph" based it ended up with weird numbers (negative signal, for example) on cases of shared deployments, and it's even worse when comparing stakes, since that's not even possible to break it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants