-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL parse/validation caching #3077
Comments
That's a good idea! For our purposes, I think it would be enough to keep a |
Reopened, due to the high CPU issue we recently had with GraphQL validations. |
Since GraphQL
parse
andvalidate
phase are static (does not depend on the user input like variables), we can implement caching for both phases (for parser:String => query::Document
, for validation:String | query::Document => Vec<ValidationError>
).This might be more relevant once #3057 lands, because if we'll add more validation rules it might add some (probably minimal) overhead.
Usually it's implemented with LRU.
The text was updated successfully, but these errors were encountered: