Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove complex cost model support #1049

Open
1 of 3 tasks
Theodus opened this issue Nov 21, 2024 · 0 comments
Open
1 of 3 tasks

Remove complex cost model support #1049

Theodus opened this issue Nov 21, 2024 · 0 comments

Comments

@Theodus
Copy link
Member

Theodus commented Nov 21, 2024

As of release v24.2.0, the gateway no longer supports "complex" cost models. The gateway only supports cost models of the form default => x;, where x is a literal value. To avoid user confusion and reduce maintenance costs, I suggest the following changes:

  • Remove the DAI injection feature. Based on a review of cost models from active indexers, this feature is not in use.
  • Remove the indexer cost set/get variables commands from the CLI
  • Replace the indexer cost set/get model with indexer cost set/get, where the user can only set a float value. At this point the @graphprotocol/cost-model dependency can be removed.
@github-project-automation github-project-automation bot moved this to 🗃️ Inbox in Indexer Nov 21, 2024
@fordN fordN moved this from 🗃️ Inbox to 📒 Todo in Indexer Dec 12, 2024
@fordN fordN moved this from 📒 Todo to ⌛ Up next in Indexer Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ⌛ Up next
Development

No branches or pull requests

1 participant