Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer-agent: missing subgraphs #912

Closed
madumas opened this issue Jun 15, 2024 · 0 comments · Fixed by #914
Closed

indexer-agent: missing subgraphs #912

madumas opened this issue Jun 15, 2024 · 0 comments · Fixed by #914

Comments

@madumas
Copy link

madumas commented Jun 15, 2024

The indexer-agent ignores rules for some subgraphs, specifically when several subgraphs have identical createdAt timestamps. The current subgraphDeployments() logic fetches 10 subgraphs at a time, using the condition createdAt_gt the last result of the previous batch. Every time more than one subgraph has the same createdAt, there is a chance that the group spans across two pages, and in such cases, some subgraphs may be missed. This is especially problematic when there are more than 10 subgraphs with the same timestamp (e.g., on the Arbitrum One network, where 14 deployments have the timestamp 1717782397).

The solution would be to stop using createdAt for pagination and use skip: fetched instead.

At the time of this report, the indexer-agent sees 5,373 subgraphs, but by changing the logic, I'm getting 6,461 subgraphs, allowing me to create allocations for subgraphs that were previously invisible to the agent.

Tasks

Preview Give feedback
No tasks being tracked yet.
@github-project-automation github-project-automation bot moved this to 🗃️ Inbox in Indexer Jun 15, 2024
@aasseman aasseman linked a pull request Jun 19, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 🗃️ Inbox to ❌ Closed in Indexer Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

1 participant