Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate names to snake-case #7

Open
aviv-ebates opened this issue Dec 19, 2018 · 2 comments
Open

Translate names to snake-case #7

aviv-ebates opened this issue Dec 19, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@aviv-ebates
Copy link

Graphene translates snake-cased python keys to camel-case gql names. gql should do the reverse translation.

@ekampf
Copy link
Collaborator

ekampf commented Dec 19, 2018

I thought about it (Lior also asked) and I don't think I want to do it.
I think that when consuming GraphQL its easier to look at the response the same way you'd look at what comes down the wire (and what's written in the docs of the API you're consuming)

@aviv-ebates
Copy link
Author

As long as pylint (etc) doesn't mind (and I guess it won't, because the code creating this is out-of-scope), it's probably fine.

@ekampf ekampf added the enhancement New feature or request label Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants