add filters alias support #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## add-filters #378 +/- ##
===============================================
- Coverage 96.37% 94.04% -2.33%
===============================================
Files 9 10 +1
Lines 773 1294 +521
===============================================
+ Hits 745 1217 +472
- Misses 28 77 +49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sabard
reviewed
Apr 24, 2023
Comment on lines
+227
to
+230
| print("got", model_field) | ||
| print(repr(model_field)) | ||
| print(model_field == 1) | ||
| print("with input", field_filters) |
There was a problem hiding this comment.
can remove in add-filters branch when we clean things up there
Comment on lines
+190
to
+192
| model_field = getattr( | ||
| model, input_field.model_attr | ||
| ) # getattr(model, field) |
There was a problem hiding this comment.
Is it possible for model_field to be None here? Looking at L#486 of types.py, couldn't a graphene.InputField be passed in to a BaseTypeFilter? Not sure if I understand the scope of this change though.
sabard
approved these changes
Apr 24, 2023
|
Manually merged into add_filters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.