-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for python 3.12 #416
Comments
Adding 3.12&3.13 support was still on my list for this library, thanks for the PR, will check it out this week! |
@erikwrede thank you! looks like we'd need to drop support for 3.7 (which has reached EOL anyways). Could also drop 3.8 which is also EOL. Any thoughts? |
@richin13 sounds good to also drop 3.8, but I'd prefer doing that together with adding 3.13 |
@erikwrede good call, I've updated the PR accordingly. As a side note, we should seriously consider upgrading dev dependencies here (adding a proper package manager, dropping SQLAchemy 1.2 and upgrading tox, to mention some) |
@richin13 also on the list. Sadly my time budget for open source (and also that of the other people with access on this project) has been a little tight this year. The idea was to switch Graphene & -sqlalchemy to Poetry |
@erikwrede gotchu! how's your time for PR reviews? I can help pushing the code updates if there's support/time to review the PRs |
+1 |
It would be super nice if you could merge the fix 🙏 @erikwrede |
@richin13 there is time for reviews.Apart from me, you can also ping @jendrikjoe @sabard @PaulSchweizer for reviews, as we all have write access. Best to just use a list, but usually its fastest to ping me. Another option is to DM me on the Graphene Discord. Thanks again, please keep the contribs coming! |
3.0.0rc2 😊 |
From the
pkg_resources
docs: setuptools.pypa.io/en/latest/pkg_resources.htmlPython 3.12 has removed
pkg_resources
from the standard library: docs.python.org/3/whatsnew/3.12.html and this project makes use of it in thegraphene_sqlalchemy/utils.py
file:graphene-sqlalchemy/graphene_sqlalchemy/utils.py
Line 8 in eb9c663
graphene-sqlalchemy/graphene_sqlalchemy/utils.py
Lines 23 to 34 in eb9c663
The text was updated successfully, but these errors were encountered: