fix(incremental): skip all empty subsequent results #3993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
This was referenced Nov 22, 2023
yaacovCR
force-pushed
the
pending-bug-fix
branch
from
1d038d6 to
af18110
Compare
yaacovCR
force-pushed
the
pending-bug-fix
branch
3 times, most recently
from
6c701c7 to
2ce309d
Compare
This has already been achieved for subsequent results that are children of the initial result, as we generated the pending notices from the list of initially published records. For subsequent results that are children of other subsequent results, we previously generated the pending notice prior to actually publishing. This change integrates the logic: the publishing method itself returns a pending notice as required. This results in a bug-fix for subsequent records of other subsequent records as well as a reduction of code for subsequent results to the initial result. This fix slightly reduces test coverage of one branch, which has been fixed in a workaround. TODO: add back missing test case.
yaacovCR
force-pushed
the
pending-bug-fix
branch
from
d10bf74 to
4d783be
Compare
This was referenced Dec 18, 2023
robrichard
approved these changes
Mar 19, 2024
yaacovCR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The publish method checks to see if a subsequent result is empty; this same logic should be employed to suppress pending notices for empty records.
This has already been achieved for subsequent results that are children of the initial result, as we generated the pending notices from the list of initially published records.
For subsequent results that are children of other subsequent results, we previously generated the pending notice prior to actually publishing.
This change integrates the logic: the publishing method itself returns a pending notice as required. This results in a bug-fix for subsequent records of other subsequent records as well as a reduction of code for subsequent results to the initial result.