Add reference types #3995
Closed
Add reference types #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
noghartt
approved these changes
Dec 10, 2023
samueldurantes
approved these changes
Mar 1, 2024
|
How could we move forward with this pr? |
|
This was discussed at the GraphQL JS WG meeting on March 27 per the notes. Summarizing from my recollection, I think this PR was felt to be a reasonable alternative, but the question was how is it better than the current option of using thunks, and balancing the desire for flexibility vs. reducing maintenance burden by having a canonical way of doing things. I am going to close this for now, feel free to reopen as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces string references for GraphQL types, which aims to solve the problem with circular dependency between types in multiple files. Here's an usage example:
This PR has only the implementation for output types for now.
I've also made a RFC repository with a patch and pratical examples for testing: https://github.com/fersilva16/graphql-refs-rfc
Contributions and feedback are welcome.