Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for consolidating grouped field sets properly into deferred fragments #3997

Merged
merged 1 commit into from
May 9, 2024

Conversation

yaacovCR
Copy link
Contributor

Group field sets should be properly consolidated when some of the fields in a sibling defer are masked by parent fields.

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 98b9868
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/663d2c42bdb2c900088701e5
😎 Deploy Preview https://deploy-preview-3997--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Dec 18, 2023
@yaacovCR yaacovCR requested a review from robrichard December 18, 2023 07:45
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR
Copy link
Contributor Author

Extracted from #3993 @robrichard

add test for correctly bundling varying subfields into incremental data records unique by defer combination, ignoring fields in a fragment masked by a parent defer
@yaacovCR yaacovCR merged commit e15c3ec into graphql:main May 9, 2024
20 checks passed
@yaacovCR yaacovCR deleted the add-test branch May 9, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants