Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GraphQL.js redirects do not work internally, and some links are broken #1957

Open
benjie opened this issue Feb 4, 2025 · 2 comments
Open

Comments

@benjie
Copy link
Member

benjie commented Feb 4, 2025

Description

GraphQL.js webpages are still included in the website, and are still searchable and navigable. However, when you reload the page you are sent to GraphQL-js.org and the webpage doesn't necessarily exist.

Steps to Reproduce

  1. Visit https://graphql.org/
  2. Enter "Running an Express GraphQL Server" into the search bar and press the top link
  3. Notice that you have been directed to https://graphql.org/graphql-js/running-an-express-graphql-server/ and a web page is rendered
  4. Reload the page (or visit https://graphql.org/graphql-js/running-an-express-graphql-server/ directly)
  5. Notice that you have been redirected to https://www.graphql-js.org/running-an-express-graphql-server/ and greeted with a 404.

Expected Result

In step 3 you should be directed to graphql-js.org (or the search result should not appear in the first place?)

If you visit https://graphql.org/graphql-js/running-an-express-graphql-server/ directly, you should be redirected to an extant page on graphql-js.org

Actual Result

Old content rendered in step 3.

404 rendered in step 5.

@benjie
Copy link
Member Author

benjie commented Feb 4, 2025

cc @JoviDeCroock @yaacovCR

@benjie
Copy link
Member Author

benjie commented Feb 4, 2025

I've partially addressed this in #1958 - most of the links work again now (by redirecting to the /docs/ URL) but we still need to solve the internal links issue - people shouldn't be able to browse to these unmaintained docs. See also #1945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant