Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnpm to v10 #51153

Open
ravicious opened this issue Jan 17, 2025 · 0 comments
Open

Update pnpm to v10 #51153

ravicious opened this issue Jan 17, 2025 · 0 comments
Labels
developer-experience Addressing these issues will improve the experience of developers working on Teleport ui

Comments

@ravicious
Copy link
Member

ravicious commented Jan 17, 2025

https://github.com/pnpm/pnpm/releases/tag/v10.0.0

Incomplete list of breaking changes that might affect us:

  • Allowlist for onlyBuiltDependencies. We'll have to figure out which packages that we use use native deps or execute other postinstall scripts.
    • pnpm rebuild might help with coming up with the list, but it's definitely not going to show you all packages. Off the top of my head, I know that electron might run some lifecycle scripts to download a fresh version of itself.
    • Maybe reinstalling all packages is going to show the full list? Maybe there's just a better command to check that? I'd expect that other people had the same problem and there's a one-liner that can tell you that.
  • public-hoist-pattern
    • Packages containing eslint or prettier in their name are no longer hoisted to the root of node_modules.

    • We already have prettier in the root package.json. All ESLint stuff is in the build package and for my money it should probably stay here.
    • If pnpm eslint no longer works, it might be better to just change the script to execute eslint from within the build package but tell it to run on all files.

Because the new onlyBuiltDependencies might protect us from supply chain attacks, I think we should backport this to all release branches that use pnpm. Mind you that the list of allowed packages might change between release branches.

@ravicious ravicious added developer-experience Addressing these issues will improve the experience of developers working on Teleport ui labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Addressing these issues will improve the experience of developers working on Teleport ui
Projects
None yet
Development

No branches or pull requests

1 participant