Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Clang build to include system headers and libclang #36309

Closed
wants to merge 1 commit into from
Closed

Update Clang build to include system headers and libclang #36309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.assets/Dockerfile-centos7-assets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
yum clean all

# Use just created devtool image with newer GCC and Cmake
FROM --platform=$BUILDPLATFORM centos-devtoolset as clang12

Check warning on line 39 in build.assets/Dockerfile-centos7-assets

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[MEDIUM] RUN Instruction Using 'cd' Instead of WORKDIR 

Details:
When using RUN command 'cd' should only be used for full path. For relative path
make use of WORKDIR command instead.

Recommendation:
Using WORKDIR to change directory

ARG DEVTOOLSET

Expand All @@ -59,7 +59,7 @@
-DLLVM_ENABLE_PROJECTS=clang \
-DLLVM_BUILD_TOOLS=ON \
-G \"Unix Makefiles\" ../llvm && \
make -j$(grep -c processor /proc/cpuinfo) install-llvm-strip install-clang-format install-clang"' && \
make -j$(grep -c processor /proc/cpuinfo) install-llvm-strip install-clang-format install-clang install-clang-resource-headers install-libclang"' && \
cd ../.. && \
rm -rf llvm-project

Expand Down Expand Up @@ -89,7 +89,7 @@

# Create the final image with Clang and custom builds only. We're using this Docker image as a tar.gz
# mainly because we want to keep our artifacts on GitHub, and GH doesn't support blobs, only Docker images.
FROM scratch AS buildbox-centos7-assets

Check warning on line 92 in build.assets/Dockerfile-centos7-assets

View check run for this annotation

Orca Security (US) / Orca Security - Infrastructure as Code

[MEDIUM] Missing User Instruction 

Details:
A user should be specified in the dockerfile, otherwise the image will run as
root

Recommendation:
The 'Dockerfile' should contain the 'USER' instruction

# Copy Clang into the final image.
COPY --from=clang12 /opt/llvm /opt/llvm/
Expand Down
Loading