Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tsh puttyconfig disable GSSApi auth #48323

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

programmerq
Copy link
Contributor

@programmerq programmerq commented Nov 1, 2024

GSSApi auth can cause PuTTY to go into "Not Responding" mode while waiting on a lookup. We can disable it in the generated PuTTY session to avoid this issue.

changelog: The tsh puttyconfig command now disables GSSAPI auth settings to avoid a "Not Responding" condition in PuTTY

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48323.d3pp5qlev8mo18.amplifyapp.com

@programmerq
Copy link
Contributor Author

I was able to build a tsh.txt on Windows with these changes. My cluster is on 16.x, so I cherry-picked this commit to branch/v16. I verified that both new settings were present in the registry, and that the PuTTY UI shows the GSSAPI auth checkboxes as disabled.

Screenshot 2024-11-05 140421

I'll remove the draft status and rebase, and mark "merge when ready"

@programmerq programmerq marked this pull request as ready for review November 5, 2024 19:30
GSSApi auth can cause PuTTY to go into "Not Responding" mode while
waiting on a lookup. We can disable it in the generated PuTTY session to
avoid this issue.
@programmerq programmerq force-pushed the jeff/puttyconfig-disable-gssapi branch from 7230e33 to 5371946 Compare November 5, 2024 19:31
@github-actions github-actions bot requested review from klizhentas and zmb3 November 5, 2024 19:31
@github-actions github-actions bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Nov 5, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from klizhentas November 5, 2024 19:31
@programmerq programmerq enabled auto-merge November 5, 2024 19:31
@programmerq programmerq added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@programmerq programmerq added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit e4f18ae Nov 6, 2024
40 of 41 checks passed
@programmerq programmerq deleted the jeff/puttyconfig-disable-gssapi branch November 6, 2024 05:41
@public-teleport-github-review-bot

@programmerq See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants