Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub proxy part 2.5: git_server cache #49564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GitHub proxy part 2.5: git_server cache #49564

wants to merge 1 commit into from
+445 −48

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 self-assigned this Nov 28, 2024
@greedy52 greedy52 added the no-changelog Indicates that a PR does not require a changelog entry label Nov 28, 2024
@greedy52 greedy52 changed the title GitHub proxy part 4: git_server cache GitHub proxy part 2.5: git_server cache Nov 28, 2024
@greedy52 greedy52 mentioned this pull request Nov 28, 2024
Open
14 tasks
greedy52
greedy52 commented Nov 28, 2024
View reviewed changes
api/client/client.go
Comment on lines +4880 to +4881
func (c *Client) GitServerClient() *gitserverclient.Client {
return gitserverclient.NewClient(gitserverpb.NewGitServerServiceClient(c.conn))
Copy link
Contributor Author

@greedy52 greedy52 Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, i realize i need a wrapper so it uses the same interface as the cache.

rest of the code just standard caching

@greedy52 greedy52 marked this pull request as ready for review November 29, 2024 01:08
@github-actions github-actions bot added size/md tctl tctl - Teleport admin tool labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GavinFrazar GavinFrazar Awaiting requested review from GavinFrazar

@smallinsky smallinsky Awaiting requested review from smallinsky

@r0mant r0mant Awaiting requested review from r0mant

@camscale camscale Awaiting requested review from camscale

@espadolini espadolini Awaiting requested review from espadolini

At least 2 approving reviews are required to merge this pull request.

Assignees

@greedy52 greedy52

Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md tctl tctl - Teleport admin tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@greedy52