Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pie chart support #30

Open
oleshiy opened this issue Jun 1, 2022 · 1 comment
Open

Add Pie chart support #30

oleshiy opened this issue Jun 1, 2022 · 1 comment
Labels
question Further information is requested

Comments

@oleshiy
Copy link

oleshiy commented Jun 1, 2022

It will be very useful and gives ability to use your for more use cases.

@zefirka
Copy link
Contributor

zefirka commented Jun 1, 2022

I see some difficulties:

  1. Fundamentals. The base of Yagr is uPlot, which certainly allows to use non-timeseries datasets (e.g. ordinal axes), but whole uPlot rendering system depends on axis-based plots, and it's the crucial issue with the pie chart. It's not possible to use uplot to render pie charts, which will bring the necessity to implement pie canvas-rendering into Yagr. And as I know uPlot don't considering to adding pie charts

  2. Typings. Whole type system should be refactored as of axis based plots are a basically the data matrix, but pie is a flat list of values (as all aggregated diagrams). This change will affect about every piece of code

  3. Motivation. The idea of Yagr is to provide fast and convenient library for timeseries charts rendering. It seems that it's very hard to overload SVG-based pie chart.

So, the resume: adding pie/donut (and other non axis-based diagrams) as a simple feature is impossible for current library code, it will require a massive refactoring and rethinking the whole approach and goals of Yagr. I can't decide it's on my own cuz it will require a lot of effort to put the Yagr on more generic rails and move away from the idea of being just a uPlot highlevel wrapper. If it will be done, it certainly will be a major update

@zefirka zefirka added the question Further information is requested label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants