Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render name of administrative boundaries on centroid #104

Closed
joakimfors opened this issue Aug 7, 2013 · 8 comments
Closed

Render name of administrative boundaries on centroid #104

joakimfors opened this issue Aug 7, 2013 · 8 comments

Comments

@joakimfors
Copy link

Names of administrative boundaries should be rendered on centroid with the appropriate size (similar to place= nodes). Issues with name collisions might occur as some "places" are mapped as both a place node and an admin boundary as the current mapnik stylesheet doesn't support place= on areas correctly (see #103 ).

@tyrasd
Copy link
Contributor

tyrasd commented Aug 7, 2013

Why "on centroid"? Shouldn't it be rendered at/near the administrative centre?

@joakimfors
Copy link
Author

Don't know if that is a good idea as for example the admin centre for a municipality could be at the same place as the admin centre of the city of the municipality. IMHO it is better to render it at or near the centroid (or on a label node but that is apparently not a solution #105 ;)).

I guess the big problem here is that place-nodes and admin boundaries often map the same thing. Putting the place= tag on the same relation as the admin boundary would be a solution if issue #103 is fixed.

@dieterdreist
Copy link

Il giorno 07/ago/2013, alle ore 14:59, Joakim Fors [email protected]
ha scritto:

I guess the big problem here is that place-nodes and admin boundaries
often map the same thing.

actually it is not the same thing but might have the same or a similar name
(e.g. Roma for the place vs Comune di Roma for the admin level 8 entity)

Putting the place= tag on the same relation as the admin boundary would be

a solution if issue #103https://github.com/gravitystorm/openstreetmap-carto/issues/103is fixed.

mostly I wouldn't do this (unless the built-up space is identical with the
administrative area)

@pnorman pnorman self-assigned this Feb 21, 2014
@pnorman
Copy link
Collaborator

pnorman commented Feb 21, 2014

Assigning to myself as a follow-up to #103, which this depends on because a portion of relations have place values

@pnorman
Copy link
Collaborator

pnorman commented Feb 21, 2014

Right now we're rendering the names via the catch-all, which is unstyled, and low priority.

image

In my mind, this can't be fixed until we handle place on areas, which requires #103. When that is fixed we may see a reduction of duplication in the data, which will help this, then we can re-evaluate if we want to render lower administrative divisions.

It is worth noting that we do render labels on centroids on low-zoom low-level administrative boundaries.

image

@mrwojo
Copy link
Contributor

mrwojo commented Feb 21, 2014

Those are place nodes in the US.

@kocio-pl
Copy link
Collaborator

If I understand this issue, current rendering is already made in centroids, using "interior" function.

Proper rendering however depends mostly on Mapnik's ability to move them aside when conflicting with admin capitals, which means that #2962 is needed (see mapnik/mapnik#3780 (comment)). Once "grid" method is available, we can use it for admin areas, but this ticket is rather not talking about it.

@matkoniecz
Copy link
Contributor

If I understand this issue, current rendering is already made in centroids, using "interior" function.

I am pretty sure that request "Render name of administrative boundaries on centroid" is fulfilled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants