-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart placing of #building-text #1661
Comments
Note that removal of |
I removed it purely for testing purposes (because I was looking for a difference), but I would be happy to check also how this option works on real map. For example this is - more or less - L-shaped building and its label is placed better without this option IMO than with it. Looking at French tiles at the same place I can see that:
and I find it even better, so it will be easy to test how it works there and it's probably another nice to have osmfr solution. However it needs some code investigating too, because their addressing.mss file is different than ours and I can't tell yet where the placement of name label on a building is defined. |
sent from a phone
not a building the positioning issues are clearly visible in the french render compared to osm carto: http://www.openstreetmap.org/relation/939256#map=14/42.4742/12.8104 |
You mean this rendering probably? Yes, it looks to me like a clear counterexample. I look for the way to relocate some labels if needed, but they shouldn't be placed outside the area border. |
Perhaps we can have |
I'm out of ideas how to fix it, so closing now. |
Smart placement of #building-text should allow us to show more names. For box
21.014,52.2316,21.0156,52.2324
on z17 in TileMill I got:current:
with added option
text-label-position-tolerance: 20;
:with added option
text-label-position-tolerance: 20;
and removedtext-placement: interior;
:Now it's clear that text-label-position-tolerance option works also for closed lines/areas, but probably only in absence of
text-placement: interior;
(or maybe any value oftext-placement
?), however it should be investigated and tested more before creating any PR.It's a proof of concept that we can really fix problems like cities/capitals being eclipsed by admin_level labels and area labels being eclipsed by other elements in the centre.
The text was updated successfully, but these errors were encountered: