Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When to update database schema #2840

Closed
kocio-pl opened this issue Sep 16, 2017 · 7 comments
Closed

When to update database schema #2840

kocio-pl opened this issue Sep 16, 2017 · 7 comments

Comments

@kocio-pl
Copy link
Collaborator

I wonder when should we update database schema. Currently we're using hstore for the things not available through the tables, but the question is which features should stay this way and which ones should be available from the standard database. Do we have to decide case by case or there are some general rules?

Example of this problem is #2494.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 8, 2017

New PostgreSQL version is expected on November 9th, 2017:

https://www.postgresql.org/developer/roadmap/

It's probably good to know if we want some database schema changes by then, because it could make server imports easier (2 in 1).

@sommerluk
Copy link
Collaborator

I’m not sure. The OSM servers seem to prefer rather yet packaged software, so I’m not sure if they will install a new version when not available as an Ubuntu update. And does upgrading PostGre require at all a database reload?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 8, 2017

I have no better knowledge and it would be good to contact sysadmins, all I know is this statement (if I didn't misunderstood something): #1286 (comment).

@sommerluk
Copy link
Collaborator

Anyway, for the next database reload – whenever it comes – it might be nice to have more fine-graded z_order values, for example for highway=road, unclassified, residential which currently have all z = 330. Using different values will make no harm, and maybe it will be useful later on.

Maybe it is also possible to avoid secondary order arguments like CASE WHEN feature IN ('railway_INT-preserved-ssy', 'railway_INT-spur-siding-yard', 'railway_tram-service') THEN 0 ELSE 1 END by integrating this directly in the of z_order calculation.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 9, 2017

It looks like PostgreSQL 10 has been released just a few days ago:

https://www.postgresql.org/about/news/1786/

@pnorman
Copy link
Collaborator

pnorman commented Oct 11, 2017

I don't see that PostgreSQL releases matter. We're not going to be using features that require 10, we're still actively supporting 9.4.

We should look at a schema when we have enough things we want to do but can't without a schema change. Right now I'm not aware of anything on that list.

If we have enough things that are particularly difficult with the current schema we could also do a schema change. The only things we currently have are fairly minor.

When looking at this, I don't really consider the OSMF ops. If we specify any reasonable version requirements they'll be able to meet them. As long as we're not requiring frequent reloads, that's not an issue either.

@kocio-pl
Copy link
Collaborator Author

Thanks, so it looks like it will be ad hoc decision, not a general plan. Currently I see no problems that are blocked by database schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants