Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make railways lighter, minor highways less prominent at z8-10 #3538

Closed
2 of 4 tasks
Tomasz-W opened this issue Nov 29, 2018 · 60 comments
Closed
2 of 4 tasks

Make railways lighter, minor highways less prominent at z8-10 #3538

Tomasz-W opened this issue Nov 29, 2018 · 60 comments

Comments

@Tomasz-W
Copy link

Tomasz-W commented Nov 29, 2018

Zoom levels 8, 9 and 10 looks like a unreadable colorful spagetti in some places at the moment:

Examples:
https://www.openstreetmap.org//#map=8/49.246/15.430
https://www.openstreetmap.org//#map=9/51.0811/5.8173
https://www.openstreetmap.org//#map=10/50.2498/19.2906
https://www.openstreetmap.org//#map=10/53.5550/-2.0627

Problems to solve:

I believe it could be cleaned similar as z13-14 was in #3467.

What do you think about it? Do you see a problem there, too?

@kocio-pl
Copy link
Collaborator

I would change the title to be more clear that it's about lines.

screenshot_2018-11-29 openstreetmap

  • I don't feel railways could be thinner, because some roads are grey already

@vholten
Copy link
Contributor

vholten commented Nov 29, 2018

During my work on the admin boundaries in issue #3526, I also noticed that on z8 and z9 county borders were too thin and railways too prominent. Therefore I made country borders on these zoom levels thicker in #3526.

I also tested making railways lighter gray on z8 and z9 and I found it looked better. I didn't show these lighter railways in #3526 because I didn't want to change too many things at the same time.
It's true that on z9 and higher there are gray roads as well so railways can't be made too light.

@Adamant36
Copy link
Contributor

I dont think protected areas borders should be thicker or brighter where the they join/overlap. It makes the map look really scrued up. For instance, in northern California it looks horrible and inconsistant.

@kocio-pl
Copy link
Collaborator

The question is how to fix it...

@vholten
Copy link
Contributor

vholten commented Nov 29, 2018

Protected area borders have shading on the inside. So borders between adjacent areas become twice as thick (shading on both sides). That could be fixed by shading that is centered on the border instead of inside.

@kocio-pl
Copy link
Collaborator

That's also what I was suspecting. Could you prepare a PR fixing that?

@Adamant36
Copy link
Contributor

Whats the reason for the borders being shaded in the first place? Is there a special reason why protected areas need to have places where they meet more visible compared to other landuse areas that just have a normal line where they meet?

@kocio-pl
Copy link
Collaborator

These are typically so big, that once you zoom in, it might be hard to know which part is inside and outside the area. Shading gives you a slight hint when the border label is not visible:

screenshot_2018-11-30 openstreetmap 2

@Adamant36
Copy link
Contributor

That makes sense. It makes things convoluted at higher zoom levels though. Like these places in northern California at z10 and z11.
protected areas boundaries z11
protected areas boundaries z10
There's also places like here on z11 where it creates a weird glowing border effect in only some places. Maybe its a bug or miss-tagging, I really don't know, but either way I've heard a lot of complaints about it and its something I've been meaning to open an issue about for awhile now. Maybe they could not have the shading at zooms higher then z16 or something. It seems to stop around there.
protected areas boundaries glowing z11
glowing border z13

@matkoniecz
Copy link
Contributor

where it creates a weird glowing border effect in only some places

Can you mark this places?

@matkoniecz
Copy link
Contributor

too prominent railways

I tested making them narrower/lighter and it resulted in many people being completely unable to distinguish them from minor roads (I was still able to do that, a small minority was also able but others not).

I considered either keeping them in current state or outright removing them as I had no idea for styling other than "narrow black/gray line".

@matkoniecz
Copy link
Contributor

Looking at it again - it seems that railway tracks at z8 may be considered for removal or for making them lighter, gray roads are not present at z8.

@Adamant36
Copy link
Contributor

@matkoniecz, here's links to a couple of the places where it does it.

https://www.openstreetmap.org/#map=13/39.4740/-122.7755
https://www.openstreetmap.org/#map=11/39.4932/-122.7214
https://www.openstreetmap.org/#map=12/39.9238/-122.9981
https://www.openstreetmap.org/#map=12/39.9317/-123.0146

I don't know if "glowing" is the right word, but there's definitely places where the borders are a lot darker green then others. There doesn't seem to be a difference between the darker and lighter places tagging or distance wise. It just looks bad and inconsistent.

@matkoniecz
Copy link
Contributor

matkoniecz commented Nov 30, 2018

I am pretty sure that it is caused by two green lines merging together - so it ends as a single strongly green line.

Merging may happen in at least two ways

  • partially transparent part os overlaid on each other and ends as strongly green
  • two green lines are located close to each other are rendered as wider/stronger green line

A similar effect is visible for railway lines with one track (fainter) or multiple tracks (stronger) on low zoom levels.

@Adamant36
Copy link
Contributor

Hhhhmmm makes sense. Something should still be done to tone it down though.

@Adamant36
Copy link
Contributor

Adamant36 commented Nov 30, 2018

@matkoniecz, what about somewhere like this where its a single line but still darker? If its because of the weird nature reserve/national park co tagging, wouldn't it just prioritize one over the other, instead of rendering them both on top of each other since its the same way?

https://www.openstreetmap.org/#map=14/40.5275/-121.2506

@kocio-pl
Copy link
Collaborator

On z8-z9 it can be changed, since the area is rendered with green overlay. On z10+ I would leave it until we find something better.

@matkoniecz
Copy link
Contributor

@Adamant36 Linked location has two lines close to each other - zoom in (say at https://www.openstreetmap.org/#map=19/40.54189/-121.27477 ) to see names - there are at least two protected areas here sharing borders.

@Adamant36
Copy link
Contributor

Hhhhmmm weird. If you go to edit it looks like only one line and you can't separate it. So....Must be an optical illusion or something.

@matkoniecz
Copy link
Contributor

Note that https://www.openstreetmap.org/way/417600197 is a member of three relations:

All three are rendered.

(and on top of that has boundary=national_park tag (I opened https://www.openstreetmap.org/note/1605307 as I suspected the last one is a tagging error)).

@Tomasz-W
Copy link
Author

Tomasz-W commented Dec 1, 2018

Old 'thinner nature reserve borders' PR to compare -> #2978

@vholten
Copy link
Contributor

vholten commented Dec 1, 2018

Here are some tests with lighter railways on z8 and z9. The idea is to fade in railways while zooming in,

  • z8: #a0a0a0
  • z9: #909090
  • z10 and higher: #787878 (this is the original railway color)

z8 current:
z8osm

z8 with lighter railways:
z8rail

z8 with lighter railways and thicker gray borders:
z8railborders

z9 current:
z9osm

z9 with lighter railways:
z9rail

z9 with lighter railways and thicker gray borders:
z9railborders

@Tomasz-W
Copy link
Author

Tomasz-W commented Dec 1, 2018

@vholten Looks very promising. I would also consider dropping rendering of smaller cities on z9.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 1, 2018

I don't feel it helps. Maybe there should be no small grey roads to make lighter railways visible.

@sommerluk
Copy link
Collaborator

Dropping placenames at z9? Yet now there are too few of them at places like https://www.openstreetmap.org/#map=9/-22.4694/20.2670

@Adamant36
Copy link
Contributor

Id be in favor of dropping grey roads at some zoom levels. Even in more rural areas they can be distracting and hinder viewing of other more important things.

For me at z9 its about viewing major roads like freeways, major water bodies/ways, and landuse. You could even almost get rid of them at z10 and id still probably be perfectly fine with it.

@vholten
Copy link
Contributor

vholten commented Dec 2, 2018

Showing gray roads at a later zoom level could help. Currently, secondary roads appear as gray roads on z9 and tertiary roads on z10. I have now changed these to appear one level later, i.e., secondary roads at z10 and tertiary ones at z11. In addition, I have slightly reduced the thickness of the colored roads.

z9 current:
z9osm

z9 new:
z9railbordersroads

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 5, 2018 via email

@Adamant36
Copy link
Contributor

I wasnt trying to insenuate that you were cropping the photos to make them look missleading. So I apologize if it sounded that way.

I just think seeing the surrounding area gives it needed context. Plus, its how it would look to a mapper on a computer. One of the main audiences for the style. It might be benificial to keep the roads for the viewing of people on mobile, but I am constantly reminded by people with more clout then me on the various OSM related projects and sites that the main page is not meant to be for mobile users and therefore will never be mobile friendly. So it shouldnt be a factor in this decisions. Although personally, I wish it could be.

As I have said, yes a lot of roads in rural areas would disapear on z9, but its just not the zoom level for it. Its not a good zoom level for finding a routing path between towns and renderings roads in grey at that level causes problems with viewing other things like rivers. I have no issue with keeping them at z10. There's no reason people cant zoom in one more level. Its a small price for better rendering. Its a balance. Otherwise, your saying z9 should look bad because its unfair to expect people to use z10 instead. When you have no proof z9 is even being used for routing purposes (it definently doesnt serve a purpose to mappers to show the grey roads at z9). The roads arent "disapearing" either. They are just going down a zoom level where its easier to view them and they dont conflict other things.

@dieterdreist
Copy link

dieterdreist commented Dec 5, 2018 via email

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 7, 2018

I've tested some renderings in Hawaii, Wales, Northern Ireland,and Delaware.
The first two have some areas that lack secondary highways, and in Hawaii sometimes the main coastal highway is only tagged as tertiary. But in Northern Ireland and Delaware (especially the later) it would be nice to remove tertiary highways from z10.

It looks like we have a problem with different standards for the different highway classifications. In Hawaii, Indonesia, parts of the West Coast of the USA and in many developing countries it is common to reserve highway=primary for roads between cities or at least between major towns, while in northern Europe it seems common that most towns are connected by highway=trunk, and even many villages are on a highway=primary. Most villages have at least a highway=secondary.

But in Indonesia and Hawaii, many towns (>10,000 people) have only a secondary or tertiary highway under the current system.

I'm willing to talk about this with the US Tagging list (unfortunately there is no active list for Indonesia), but I don't know if USA mappers are interested in using highway=trunk instead of highway=primary for most US highways and major state highways, so that highway=primary can be used for frequently.

Oahu to Maui, current z9:
oahu-maui-z9-current

z9 without secondary highways:

  • No roads now visible to connect to two towns on Moloka'i (center)
  • Roads missing in northwest Oahu (left) and southeast Maui (right), leaving towns disconnected
    oahu-maui-z9-no-secondary

Maui z10, current
maui-z10-current

z10, no tertiary

  • towns on east of island are now disconnected
    maui-z10-no-tertiary

Oahu z10, current
z10-oahu-current

  • You can see that the secondary roads in the north and northwest would be eliminated at z9

Hawaii (Island), current z9:
hawaii-z9-current

z9 without secondary:

  • missing connection between primary road in center and west coast of island.
  • town of Kapaau in north is disconnected
    hawaii-z9-no-secondary

Hawaii, z10
n-hawaii-z10-current

z10 without tertiary

  • not a big difference here
    n-hawaii-z10-no-tertiary

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 7, 2018

Wales, z8 - this will not change
wales-z8

Northern Wales, z9 Before
n-wales-z9-current

Without secondary highways

  • The peninsula on the lower left looks roadless
    n-wales-z9-no-secondary

Pwllheli z10 current
pwllheli-z10-current

z12 - yes, there are roads and villages here
z12-pwllheli

Southern Wales, z9 current
s-wales-z9-current

Without secondary highways
s-wales-z9-no-secondary

Swansea z10 current
swansea-z10-current

Without tertiary
z10-swansea-no-tertiary

z12 - to show villages and tertiary roads clearly
z12-sw-swansea

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 7, 2018

Northern Ireland has a large number of trunk roads, which connect most of the towns. There are a couple of places where removing secondary roads at z9 might be a problem, but removing tertiary from z10 will not be harmful in this area.

Northern Ireland, z8

  • would not change
    n-ireland-z8-current

z9 Current
n-ireland-z9-current

Without secondary
n-ireland-z9-no-secondary

Derry z10 Current
derry-z10-current
Without tertiary
derry-z10-no-tertiary

Enniskillen z10 Current
enniskillen-z10-current
Without tertiary
enniskillen-z10-no-tertiary

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 7, 2018

Delaware has many roads tagged at highway=trunk connecting the main towns. It looks like a few places are tagged as villages that might actually qualify as towns in the southwest corner? But there is certainly no problem with removing secondary roads here, and hiding tertiary roads on z10 will look nice in Delaware:

z10 before
s-delaware-z10-current

z10 without tertiary
s-delaware-z10-no-tertiary

@Adamant36
Copy link
Contributor

@jeisenbe, there's a page on the wiki about USA road tagging and it seems like there was any agreement reached as to how it should be. So I'm not sure your statement about them using highway=trunk instead of highway=primary for most US highways and major state highways necessarily holds true. There's wide variance here depending on the state and the whims of the mappers. A lot of it probably has to do with lack of education about road classifications (most people I've talked to about the subject don't even know they exist or that something like urban planning is a thing). Plus, people have a major tendency to re-tagged things that are already tagged correctly based on their whim anyway.

Also, the TIGER import screwed most of the roads up here a while ago and largely hasn't been fixed. It made a lot of roads more minor then they should have been and wrongly tagged a large amount of track/service roads as residential.

So I don't think we should use America or reading into it as an example of why to go through with idea. It should be based on if things look better or not in those areas, but not on the theoretical preferences of the mappers here. Although, its still worth bringing up in the USA talk list anyway.

@Adamant36
Copy link
Contributor

@jeisenbe, also just for clarification are you against this road change completely, just with certain road types, or? Further, have put any thought or done any tests on the suggesting made by and Dieterdreist just to make the roads more visible instead? I'm not that up on how road rendering works, but I might be into just making them easier to see instead of getting rid of them.

I'd like to see test renderings of both to compare the options though. So if you want to forgo disappearing roads for now, since we all essentially get what it entitles, and work making them more visible instead that would be good. Its pretty obvious at this point that some places would benefit from them being removed and some wouldn't.

@kocio-pl
Copy link
Collaborator

Anybody interested in fixing protected area borders on z8-z9?

@Tomasz-W
Copy link
Author

I think we should focus on original propositions of this ticket and eventually come back to dropping tertiary roads on z10 at the end (examples above shown that dropping secondary roads on z9 is a bad idea).

  • bolder country borders on z8-9
  • thinner protected areas borders on z8-10
  • lighter railways on z8-10

@vholten
Copy link
Contributor

vholten commented Dec 14, 2018

I've experimented more with making railways less prominent. On z8 this can be done easily: there are no gray roads, so there is no possible confusion between railways and roads.

On z9, secondary roads are shown in gray. If railways are made lighter, it becomes harder to distinguish secondary roads from railways. A possible solution is to remove secondary roads from z9, but this is controversial. Another solution is to make secondary roads a bit lighter as well.

Here I show the result of the following changes on z9:

z9 before:
z9osm

z9 after:
z9preview2

@Tomasz-W
Copy link
Author

Tomasz-W commented Dec 14, 2018

Surely it's an improvement, but I have some remarks to consider:

  • primary roads might be a little bit thicker than rest of roads as they make a skeleton of road system
  • secondary roads are too light and hard-visible
  • railways can be a little bit thicker
  • I'm wondering if some kind of simple railway pattern would work on these zoom levels

@matkoniecz
Copy link
Contributor

On z8 this can be done easily: there are no gray roads, so there is no possible confusion between railways and roads.

My intention was to avoid user thinking that gray lines on z8 are roads (maybe costs of this make it not worth doing, I just wanted to explain reasons for that).

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 15, 2018 via email

@Tomasz-W
Copy link
Author

@jeisenbe I'm sure that adding more colours will rather make this mess bigger instead of reduce it.

@Adamant36
Copy link
Contributor

I'd like to see minor unclassified roads rendered differently then residential. So if adding more colors would help with that I'm for it. Otherwise, not so much and I agree with @Tomasz-W omasz-W that it would just be over complicating things. The only other viable solution I see is not rendering minor roads at higher zoom levels.

Otherwise, you'll have to reinvent the whole wheel just to patch a small hole in the outer tube (in this case changing the rendering of all or most of the roads, just to make railroads look better.

To me it seems a way better option would be the road rendering deprioritizion option, which would resolve other issues also, but that's already been shot down due to the few examples where it would be a problem (which is really debatable anyway), at the expense of the many places that would benefit from it.

Implementing some of @Tomasz-W suggestions in #3538 (comment) might work also (including a railway pattern). I'd like to see them tried out first before the wheel reinvention commences.

@vholten
Copy link
Contributor

vholten commented Dec 15, 2018

A railway pattern would be a way to distinguish railways from roads, but the pattern that we currently use would make railways even more prominent at low zooms instead of less.

The TileMill documentation has an example with a more subtle railway pattern:

A common way of symbolizing railroad lines is with regular hatches on a thin line. This can be done with two line attachments - one thin and solid, the other thick and dashed. The dash should be short with wide spacing.
styling-lines-9

@Adamant36
Copy link
Contributor

@vholten, to me its 50/50 between making it less prominent versus making it clearly distinguishable from roads. A patter might make it stand out more, but at least its clear its a railroad that way. I'm not sure if it balances out though.

@Tomasz-W Tomasz-W mentioned this issue Jan 3, 2019
@jeisenbe jeisenbe changed the title Clean up z8-10 Make railways lighter, minor highways less prominent at z8-10 Sep 5, 2019
@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 5, 2019

Updated title to match 2 remaining suggestions: lighter railways, less prominent minor highways at z8-10.

@dieterdreist
Copy link

dieterdreist commented Sep 6, 2019 via email

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 6, 2019

Agreed. I'm inclined to close this issue, since the test images above did not seem to be a clear improvement in all areas.

The current use of highway tags is quite different in places like England vs developing countries and North America, so it's difficult to get an ideal rendering for all countries with a global stylesheet. Rendering tertiary or secondary roads at a later zoom level would be an improvement in places like England, but not in western Australia or eastern Indonesia.

And currently roads and railways keep mostly the same colors at different zoom levels - changing railways to a lighter color would make it more difficult to distinguish them from minor roads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants