Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure features are still queryable when user is told to zoom in first #3809

Closed
jidanni opened this issue Jun 19, 2019 · 12 comments · Fixed by #3879
Closed

Make sure features are still queryable when user is told to zoom in first #3809

jidanni opened this issue Jun 19, 2019 · 12 comments · Fixed by #3879
Assignees

Comments

@jidanni
Copy link

jidanni commented Jun 19, 2019

It doesn't matter what the reason is, just make sure you don't "play
bait and switch" with the user... especially as he has to mouseover the
"Zoom in to query features" button at each zoom level to see if it has
finally changed its name to "Query features".

On https://www.openstreetmap.org/#map=11/25.5688/-80.4893 user sees
plenty of airports.

User clicks the "Zoom in to query features" button... OK, he needs to
zoom in first before he can query "Redland Field".

Finally https://www.openstreetmap.org/#map=14/25.5448/-80.4574 the "Zoom
in to query features" button now is called "Query features", but alas,
it is just at this zoom level that "Redland Field" has disappeared from
the map!

Even if #2664 / #232 are resolved, it is just going to happen again for some
other feature.

All the user knows it he is told to zoom in to query, but then the thing
disappears, "like one big practical joke". He looks over his shoulder to
see if this isn't one more trick his office mate set up on his computer
like the last time he went for coffee break without locking the keyboard.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jun 20, 2019 via email

@Adamant36
Copy link
Contributor

There's also #1143. Which has some good suggestions.

@jeisenbe
Copy link
Collaborator

@jidanni have you seen this problem with any features other than airports? If not, I believe it will be fixed by PR #3856

@jeisenbe jeisenbe removed the POI label Aug 31, 2019
@jeisenbe jeisenbe self-assigned this Aug 31, 2019
@jeisenbe jeisenbe added this to the Bugs and improvements milestone Aug 31, 2019
@jidanni
Copy link
Author

jidanni commented Aug 31, 2019

@jeisenbe here a big city is pushed off the map by little cities nearby, as apparently size, not population, is all that can be used to choose which to sacrifice. (As population has no place in the database.)

@jeisenbe
Copy link
Collaborator

Do you have a link that isn't through facebook, perhaps directly to the object on openstreetmap.org or the approximate location on the map? It would help to know the feature tag (place=city?) and population.

If I understand correctly, you don't like it that place=city labels disappear at a certain zoom level.

This is done so that place=quarter and place=neighborhood labels can be shown at zoom levels when the city is taking up the whole screen. Actually we use population= for this, but don't consider area, since only place= nodes are rendered for settlements including cities, towns and neighborhoods. If there is no population= tag, we guess that untagged towns are population=1000 and untagged cities population=100,000 (probably that should be dropped to 50k or 20k for cities).

Text labels for large cities are last rendered at z13, mid-size cities at z14, towns at z15; place=suburb, quarter and village at z16, hamlet at z18. The idea is that above these zoom levels, the larger place should be filling up just about the whole screen.

In my place=city (name="Wamena"), there is also a node with place=neighbourhood and name="Kota Wamena" meaning "City Centre" or "Downtown" in English, for the city centre neighbourhood, so this shows up at the higher zoom levels when the city label disappears. If the city label was always shown, it would block the neighborhood name at many zoom levels.

@jidanni
Copy link
Author

jidanni commented Sep 1, 2019

@jeisenbe:
https://www.openstreetmap.org/?#map=11/23.9797/121.6070&layers=T and at
lower zooms, the big city of
https://en.wikipedia.org/wiki/Hualien_City 花蓮市
https://www.openstreetmap.org/relation/3410979
is missing, and only appears at
https://www.openstreetmap.org/?#map=12/23.9770/121.6077&layers=T and
higher zooms.

Comparing

Anyway I hope somebody will file bugs for the layers involved.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 1, 2019

But the initial issue is about features disappearing too soon. Hualien (花蓮市) should be rendered from z9 to z15, so I believe this isn't a problem? At z15 Hualien appears to take up the whole screen.

Your link is to the relation with id 3410979 - this style does not render place=town mapped as areas (multipolygon relations or closed ways) or as boundary relations. So we are not actually rendering that, but the place node https://www.openstreetmap.org/node/60655639 - this is a place=town with population=105034 and name=花蓮市

The nearest town to the north which renders is https://www.openstreetmap.org/node/60655838:
name=新城鄉 (name:en= Xincheng), a place=town with population=20274

We render all place=town the same; only place=city get a larger text label (depending on population).

population=105034 is quite large for a place=town. I don't know what standards the Taiwan mapping community uses to map a place as city instead of town, but globally over 98% of place=town that have a tagged population have a population value less than 100,000, and 38% of place=city have population < 100,000. See Talk:Tag:place=town and Talk:Tag:place=city for more details.

But I see now that Taiwan has no place=city with less than 250k people. That's quite unusual; the average size place=city in the database has population ~ 140k. Perhaps talk to the local mappers about this? Even in Taiwan less than 10% of place=town have pop > 100k (21 out of 227).

We could change our rules to treat place=town with population > 70k the same as place=city, but this wouldn't give mappers proper feedback about the tagging.

@jidanni
Copy link
Author

jidanni commented Sep 2, 2019

Perhaps go back to using strict population comparisons:
4
5

@polarbearing
Copy link
Contributor

What relation has the Query Feature button on the OSM website to this style?

@pnorman
Copy link
Collaborator

pnorman commented Sep 2, 2019

What relation has the Query Feature button on the OSM website to this style?

None

@jidanni
Copy link
Author

jidanni commented Sep 2, 2019

Oops conversation drifted...

@jeisenbe
Copy link
Collaborator

I've set this issue as closed with #3879 because we are not directly in control of whether features can by queried at any particular zoom level - this is determined by the openstreetmap.org website team. The PR now renders airports later in most cases, so the main problem mentioned in this issue should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment