Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render private slipways differently #4077

Open
Adamant36 opened this issue Mar 15, 2020 · 4 comments
Open

Render private slipways differently #4077

Adamant36 opened this issue Mar 15, 2020 · 4 comments
Labels

Comments

@Adamant36
Copy link
Contributor

Adamant36 commented Mar 15, 2020

Currently there is 1,294 uses of the access tag on slipways. Although only 485 of those are access=private, adding half-transparency to the ones that are might encourage more mapping of private ones. Plus, it would help map viewers to not confuse private slipways with public ones.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Mar 15, 2020

I've changed the title to "Render private slipways differently", since using transparency is not the only option.

See previous discussions about the problems with using transparency:

#552 (comment): "I've said this before and I'll say it again. No transparency."

"Transparency tends to make the colours ugly, so we prefer to avoid it." #529 (comment)

@jeisenbe jeisenbe changed the title Render private slipways with half-transparency Render private slipways differently Mar 15, 2020
@jeisenbe
Copy link
Collaborator

See problems with the current rendering of private feature icons with transparency in #3589, and some possible solutions

@Adamant36
Copy link
Contributor Author

While I mostly agree with the problems with the current transparency rendering of private features, transparency has already been implemented for years now as a way to render private icons and I don't see it being such a big problem that it's worthy of putting on hold rendering any new private features that way. There are plenty of things that could be rendered better, but aren't killers to anything and I'd put using transparency in that category. Especially since the opposition to it is really only a few comments from like 6 years ago, in issues that aren't specifically about transparency rendering problems. You could pick and chose single negative comments from any issues and use them a reason not to do something.

Also, the possible solutions where only briefly discussed and never got off the ground. If transparency should be discarded for something else though, which I somewhat agree it ultimately should be at some point, then there should be a meta issue or something about that specific thing. Otherwise, it's off topic and distracts from the purpose of the current issue. The fact that there isn't a specific issue about transparency and there's only a single issue complaining about it by someone who only opened the issue because they didn't know the rendering of toilets had changed, which had nothing to do with the problems of transparency, makes me think it's not really that much of a problem.

@jeisenbe jeisenbe added the POI label Mar 15, 2020
@jeisenbe
Copy link
Collaborator

See #4078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants