Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please render sports_centre #4697

Closed
BertMule opened this issue Sep 26, 2022 · 4 comments
Closed

Please render sports_centre #4697

BertMule opened this issue Sep 26, 2022 · 4 comments
Labels
wontfix-unfeasible Issues closed because of lack of suitable solution

Comments

@BertMule
Copy link

BertMule commented Sep 26, 2022

https://www.openstreetmap.org/#map=19/51.75357/3.85196

I have added 2 sports_centre as follows.

leisure=sports_centre
sport=<sport>

They do not show up in any way.
Frustrating as ever.

Maybe there is some magic combination of tags to succeed, which I have not yet discovered.
But this should be simple.

Please render this.

Adding a name renders that.
But I would expect some icon without a name.

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Sep 26, 2022

They are rendered (when not the same as a building):
https://www.openstreetmap.org/way/549930092

What object is missing a rendering?

You mean https://www.openstreetmap.org/node/10053730860 ?
This is rendered with a name.
image

Your issue is probably a duplicate of #844

@imagico
Copy link
Collaborator

imagico commented Sep 26, 2022

We render leisure=sports_centre with a name label. And we have #844 for ideas for sport specific rendering.

If you have a concrete idea for a generic rendering other that with a name label that works for all kinds of sports and that provides useful additional information that would be of interest. It seems unlikely to me that this is feasible though. Closing this as unfeasible (for not sport specific rendering other than a name label), as duplicate of #844 for sport specific rendering and as invalid for the lack of rendering in general.

@imagico imagico closed this as completed Sep 26, 2022
@imagico imagico added the wontfix-unfeasible Issues closed because of lack of suitable solution label Sep 26, 2022
@BertMule
Copy link
Author

BertMule commented Oct 4, 2022

I really wish you would at least apply generic icons or name-behaviour to entities.
This is already strongly suggested by the use of one within the ID-editor (a running figure).
So often the icons are already available.
Even more specific, like for pitches.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 4, 2022

@BertMule this style usually renders an icon when a feature is mostly mapped as a node or building, such as shops and other small amenity features.

When a larger feature is usually mapped as an area of ground, including several smaller buildings, it maybe rendered with a color for the area, plus a name label. In that case we do not usually have an icon, because the area is rendered instead.

In the case of leisure-sports_centre there is a rendering for the area in @stadium (@leisure) color, since often this includes several buildings, pitches, a pool etc -

[feature = 'leisure_sports_centre'],
[feature = 'leisure_water_park'],
[feature = 'leisure_stadium'] {
[zoom >= 10] {
polygon-fill: @stadium;

There is also a rendering for the name -

[feature = 'leisure_sports_centre'],
[feature = 'leisure_stadium'] {
text-fill: darken(@stadium, 70%);

Similarly, schools and parks have a rendering for the area, but do not have an icon because the meaning is usually understood from the context and name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix-unfeasible Issues closed because of lack of suitable solution
Projects
None yet
Development

No branches or pull requests

4 participants